Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New drives are always removable #952

Open
alexandrosm opened this issue Dec 6, 2016 · 12 comments
Open

New drives are always removable #952

alexandrosm opened this issue Dec 6, 2016 · 12 comments

Comments

@alexandrosm
Copy link
Contributor

alexandrosm commented Dec 6, 2016

Not sure if this belongs here or in drivelist, but it just dawned on me that Etcher should consider drives that appeared after it was started as removable, even if detected as "system" for whatever reason. Is it a correct assumption to say that a system drive does not appear/disappear at runtime?

As a bonus item, if users are having "system drive" issues, we could always ask them to insert the media after they started Etcher, right? (though this will be ameliorated with the new "unsafe mode" adaptations).

@jviotti
Copy link
Contributor

jviotti commented Dec 6, 2016

Is it a correct assumption to say that a system drive does not appear/disappear at runtime?

Maybe. This means that removable USB hard drives, for instance, will be considered safe to write to, but the UX pattern definitely makes sense to me.

@lurch
Copy link
Contributor

lurch commented Dec 7, 2016

I guess it also depends what we decide "system drive" to mean? AFAIK there's not really yet any good definition of what that means, and I wonder if there should be? (I think at the moment it's any drive which drivelist identifies as non-removable?)

@jviotti
Copy link
Contributor

jviotti commented Dec 7, 2016

Yeah, as mentioned in balena-io-modules/drivelist#126, the proposal is to rename "system" to mean "non-removable" and add a new "system" property that is only true when that drive contains an operating system installed (e.g: the hard drive containing / in Linux, or usually C: in Windows).

After making such changes, the feature discussed here starts making more sense, since we'll whitelist non-removable drives that are non-system drives if they are inserted after Etcher is already running.

@konmouz
Copy link

konmouz commented Dec 7, 2016

Will Etcher still auto-select a drive with the multi-write functionality? Does it make sense to auto-select a drive that appeared after Etcher started? Currently, the auto-select feature is great but wouldn't be that straightforward in the next version.

@lurch
Copy link
Contributor

lurch commented Dec 7, 2016

I think the auto-selection does still make sense (even with multi-write). It would only auto-select if there was a single removable drive detected (even if that removable drive is inserted after Etcher has started). Anything else will require manual user interaction.

@jviotti jviotti modified the milestones: Backlog, Experience Dec 7, 2016
@alexandrosm
Copy link
Contributor Author

However, this does imply that even after auto-selection, we would have a CTA button to open the drive menu, right?

@konmouz
Copy link

konmouz commented Dec 8, 2016

Currently we use 'change' for that. There will be a similar interaction.

@estevesd
Copy link

estevesd commented Aug 15, 2017

Still seeing this issue on the last version (1.1.2)
I'd love to see this fixed.
I'm trying to copy an image directly to a mSATA drive. For that I'm using a mSATA to USB adapter which is sadly not detected as a removable drive.
It seems indeed logical that a drive added at runtime should be assumed as being removable !!
In the mean time : Back to CLI

@lurch
Copy link
Contributor

lurch commented Aug 15, 2017

@estevesd Or you could simply enable the "unsafe mode" in Etcher's settings, which will then allow you to write to "system" drives 😀

@konmouz
Copy link

konmouz commented Aug 15, 2017

At some point, it would be good to remove this option from settings and move it directly under the drives list as proposed.

@lurch
Copy link
Contributor

lurch commented Aug 15, 2017

@konmouz Yeah, I still think #888 is worth doing, it just isn't top of our priority lists at the moment.

@konmouz
Copy link

konmouz commented Aug 15, 2017

@lurch, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants