feat: events apps new install flow #14616
Conversation
…w' into new-app-install-flow
… install flow if it is an oAuth app or an app that extends the EventType feature in it's config
|
as a follow up PR i would love to have this onboarding flow when adding a new conferencing tool to select which event type it should be installed on as a location adding conferencing apps and then going to each event type manually is not intuitive right now |
| @@ -35,7 +35,7 @@ const ScrollableArea = ({ children, className }: PropsWithChildren<{ className?: | |||
| className // Pass in your max-w / max-h | |||
| )}> | |||
| {children} | |||
| {isOverflowingY && <div style={overflowIndicatorStyles} data-testid="overflow-indicator" />} | |||
There was a problem hiding this comment.
Why was this removed? We get a warning of unused styles. If it's not needed then let's remove it completely.
There was a problem hiding this comment.
it adds this shadow at the top, i think we can remove this, since <ScrollableArea /> is not being used anywhere else and the scroll bar clearly indicates that there's more content to see.
There was a problem hiding this comment.
We're almost there. Just need a little bit more context. IDK if you or @ThyMinimalDev can provide it. Why was this reverted in the first place? Was was failing back then that should be fixed by now?
|
On another note. It seems like for some reason this PR is messing with rescheduling behavior? |
The revert occurred because we were redirecting the installation of Zoom to the flow |
looking into it |
|
not entirely sure if the failing tests are related |
What does this PR do?
Fixes #13414
Fixes CAL-3029
LOOM 1
LOOM2
this PR is a collective PR for different PRs(#11975 and #14077) that were tested individually and merged together into this pr
Requirement/Documentation
Type of change
How should this be tested?
checkout the looms, they explain the "How" to in great detail.
-testcasses:
Mandatory Tasks