Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPF - Use WpfImeKeyboardHandler for supported KeyboardLayoutIds #4439

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WPF - Use WpfImeKeyboardHandler for supported KeyboardLayoutIds #4439

wants to merge 1 commit into from

Conversation

amaitland
Copy link
Member

@amaitland amaitland commented Mar 29, 2023 •
edited

Fixes: #1262

Summary:

  • Determine which keyboard handler to use based on CurrentInputLanguage

Changes:

  • Setup default keyboard handler based on CurrentInputLanguage
  • Detect changes in input language

How Has This Been Tested?
Minimal Testing, requires user feedback

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

@amaitland amaitland mentioned this pull request Mar 29, 2023
Open
@AppVeyorBot
Copy link

✅ Build CefSharp 111.2.20-CI4733 completed (commit 04ba15bbee by @amaitland)

amaitland
amaitland commented Oct 14, 2023
View reviewed changes
CefSharp.Wpf/ChromiumWebBrowser.cs
@@ -769,6 +776,32 @@ private void InternalDispose(bool disposing)
Cef.RemoveDisposable(this);
}

private void SetupWpfKeyboardHandler()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this protected and add xml doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amaitland @AppVeyorBot