Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling #16212

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Spelling #16212

wants to merge 35 commits into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 1, 2023

As discussed in #16204

Fixes misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/fsharp/actions/runs/6720404664/attempts/1#summary-18263884401

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/fsharp/actions/runs/6720404656/attempts/1#summary-18263884386

@jsoref jsoref requested a review from a team as a code owner November 1, 2023 13:50
@psfinaki
Copy link
Member

psfinaki commented Nov 1, 2023

Damn... did not think it would be that bad :D
Hey do you think we could have these changes in chunks? Like, 100-150 in each so that this is more manageable to review? We could go by projects or folders.

jsoref
jsoref commented Nov 1, 2023
View reviewed changes
Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll continue annotating this PR later...

docs/tooling-features.md Show resolved Hide resolved
fcs-samples/FsiExe/console.fs Show resolved Hide resolved
release-notes.md Outdated Show resolved Hide resolved
src/Compiler/AbstractIL/ilpars.fsy Show resolved Hide resolved
src/Compiler/AbstractIL/ilreflect.fs Outdated Show resolved Hide resolved
src/FSharp.Core/array.fs Outdated Show resolved Hide resolved
src/FSharp.Core/resumable.fs Show resolved Hide resolved
tests/FSharp.Compiler.ComponentTests/CompilerOptions/fsc/flaterrors/env.lst Show resolved Hide resolved
...Compiler.ComponentTests/Conformance/BasicGrammarElements/EntryPoint/E_invalidsignature001.fs Show resolved Hide resolved
...nce/BasicGrammarElements/MemberDefinitions/MethodsAndProperties/E_AbstractAndConcreteProp.fs Outdated Show resolved Hide resolved
@jsoref
Copy link
Contributor Author

jsoref commented Nov 1, 2023

Sigh, I'll replace params and value with params_ and value_...

@vzarytovskii
Copy link
Member

Hey do you think we could have these changes in chunks?

please no, it will kill git history, this way we only need to ignore one revision.

@jsoref
Copy link
Contributor Author

jsoref commented Nov 1, 2023

Damn... did not think it would be that bad :D

For a project of this size, it's about as I'd expect (larger projects can get to ~1k commits).

@jsoref
Copy link
Contributor Author

jsoref commented Nov 1, 2023

I'm on an m1 mac and can't figure out how to run the UpdateXlf thing. I have a mono, but that didn't help.

https://visualstudio.microsoft.com/vs/preview/#download-preview offers me an .exe which seems unhelpful on Darwin/macOS...

I'm tempted to just punt on the changes related to this.

@jsoref jsoref force-pushed the spelling branch 4 times, most recently from 824ffd2 to e8516b5 Compare November 1, 2023 21:53
@jsoref
Copy link
Contributor Author

jsoref commented Nov 2, 2023

/run xlf

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Ran xlf: https://github.com/dotnet/fsharp/actions/runs/6732262393

@jsoref jsoref force-pushed the spelling branch 2 times, most recently from 548539d to 3da75d3 Compare November 3, 2023 14:25
jsoref
jsoref commented Nov 3, 2023
View reviewed changes
Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is close to passing basic CI. I'm about halfway through annotating things. I'm off to visit a museum... I'll probably look back next week.

tests/fsharpqa/Source/Conformance/TypeForwarding/Class/env.lst Show resolved Hide resolved
src/Compiler/xlf/FSComp.txt.cs.xlf Show resolved Hide resolved
src/Compiler/xlf/FSComp.txt.de.xlf Show resolved Hide resolved
vsintegration/src/FSharp.ProjectSystem.PropertyPages/PropertyPages/BuildPropPage.resx Outdated Show resolved Hide resolved
vsintegration/src/FSharp.ProjectSystem.PropertyPages/PropertyPages/PropPageUserControlBase.vb Outdated Show resolved Hide resolved
tests/fsharp/core/quotes/test.fsx Show resolved Hide resolved
tests/fsharp/core/seq/test.fsx Show resolved Hide resolved
vsintegration/src/FSharp.LanguageService.Base/EditArray.cs Outdated Show resolved Hide resolved
vsintegration/src/FSharp.ProjectSystem.Base/DataObject.cs Show resolved Hide resolved
vsintegration/src/FSharp.ProjectSystem.Base/Interfaces.cs Show resolved Hide resolved
@jsoref jsoref force-pushed the spelling branch 2 times, most recently from 654ca11 to cb505a9 Compare November 6, 2023 03:53
psfinaki
psfinaki reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh, thanks for your grit. Looks like we are getting there... I am reviewing this, slowly but steadily :)

Looks like some of the spelling stuff spills to the user surface, so this benefits the language image also.

...rc/FSharp.ProjectSystem.PropertyPages/Resources/Microsoft.VisualStudio.Editors.Designer.resx Outdated Show resolved Hide resolved
vsintegration/src/FSharp.ProjectSystem.Base/Microsoft.VisualStudio.Package.Project.resx Show resolved Hide resolved
tests/fsharpqa/testenv/bin/runall.pl Show resolved Hide resolved
tests/fsharp/core/members/stephen.ml Outdated Show resolved Hide resolved
@jsoref jsoref force-pushed the spelling branch 3 times, most recently from 206b8fc to 3691487 Compare November 6, 2023 14:39
jsoref
jsoref commented Nov 7, 2023
View reviewed changes
Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the last round of me flagging interesting things -- I have one more push pending past this, and I think I have one or two more rounds of trying to fight CI, but at this point, it's very close to done and it's definitely quite reviewable.

tests/FSharp.Compiler.ComponentTests/Conformance/Types/UnionTypes/E_FieldMemberClash.fs Outdated Show resolved Hide resolved
tests/FSharp.Compiler.ComponentTests/Conformance/Types/UnionTypes/ReflectionOnUnionTypes01.fs Show resolved Hide resolved
tests/FSharp.Compiler.ComponentTests/ErrorMessages/InterfaceImplInAugmentationsTests.fs Show resolved Hide resolved
tests/FSharp.Compiler.ComponentTests/Interop/DeeplyNestedCSharpClasses.fs Outdated Show resolved Hide resolved
tests/FSharp.Compiler.ComponentTests/Language/ObsoleteAttributeCheckingTests.fs Show resolved Hide resolved
tests/fsharpqa/Source/Misc/WhetherEmbeddedManifest.fs Outdated Show resolved Hide resolved
tests/service/data/SyntaxTree/DotLambda/UnderscoreToFunctionCallWithSpaceAndUnitApplication.fs Outdated Show resolved Hide resolved
vsintegration/src/FSharp.Editor/Navigation/GoToDefinition.fs Outdated Show resolved Hide resolved
vsintegration/src/FSharp.ProjectSystem.Base/ProjectOptions.cs Show resolved Hide resolved
vsintegration/tests/MockTypeProviders/DefinitionLocationAttribute/ArtificialEventInfo.cs Outdated Show resolved Hide resolved
@jsoref
Spelling immediate..initial
954074b 
* immediate
* immediately
* immutable
* implement
* implementation
* implicit
* implies
* in fact
* in-initial
* inaccessible
* include
* including
* inconsistencies
* incorrect
* increment
* indeterminate
* indicate
* indicates
* indicating whether
* inference
* inferred
* information
* information to
* inherit
* inherited
* initial

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: initialization
af7631e 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling initialize..intellisense
a024ba7 
* initialize
* initialized
* initializers
* initiate
* initonly
* inner
* insensitive
* install
* instance
* instances
* instantiated
* instantiation
* instantiations
* instead
* integer
* intellisense

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling interface..length
a573c35 
* interface
* interfaces
* internal
* interoperability
* interpolation
* interpretation
* interpreted
* interrupt
* into
* intrinsic
* intrinsics
* invalidate
* invalidation
* invocables
* involves
* iproperty
* irritating
* isolate
* items
* its
* itself
* kernel
* keybindings
* known
* knownfail
* labels
* lambda
* lambdas
* language
* length

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling level..mercury
b87b50a 
* level
* levenshtein
* libraries
* library
* likewise
* limited
* list
* listeners
* listening
* literal
* logged
* looking
* machine
* macos
* management
* manager
* manifest
* manipulation
* manufacturer
* mapping
* masked
* matched
* matches
* measurable
* measurement
* mechanism
* member
* members
* mercury

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling message..node
b711c4f 
* message
* method
* milliseconds
* mismatch
* misspelled
* mistyped
* mmapped
* modification
* modified
* modifier
* module
* moniker
* monochrome
* multi
* multiplatform
* multiple
* multiply
* mutual
* namespace
* necessary
* negative
* nested
* new
* node

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling nonexistent..occurred
2c9d5dd 
* nonexistent
* now
* number
* numeric
* observers
* occur
* occurred

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling occurrence..optimization
99fa6b6 
* occurrence
* occurrences
* occurring
* of
* omitted
* only
* open
* operation
* operators
* optimization

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling optimizations..parallel
48330cb 
* optimizations
* optimizer
* optional
* or
* ordinal
* original
* other
* outer
* outerclass
* outlining
* output
* overloading
* overridable
* overridden
* override
* overwriting
* overwritten
* package
* parallel

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling parameter..performed
ca1c185 
* parameter
* parameterized
* parameters
* parentheses
* parenthesis
* parenthesized
* parenthetical
* parsable
* particular
* partition
* partitioning
* passed
* path
* paths
* performed

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling persisted..preferences
c64dcad 
* persisted
* perspective
* piece
* pipelines
* platform
* polymorphic
* portable
* position
* positive
* possibilities
* possibility
* postalcode
* postfix
* potentially
* powers
* preceded
* precedence
* precedes
* precisely
* precision
* predecessors
* preexisting
* preferences

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling preprocessor..reentrancy
3d61737 
* preprocessor
* prerequisites
* previously
* processed
* processing
* production
* profiling
* programmatically
* project started
* projects
* propagate
* propagated
* properties
* property
* proxies
* qualify
* quantile
* quick
* quotation
* quotations
* quoted
* raises
* received
* recognizes
* record
* records
* recordtype
* recreate
* recursive
* recursively
* reduction
* reentrancy

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling reference..reserved
74f03a1 
* reference
* references
* refresh
* regardless
* regression
* relaxation
* release
* remaining
* remember
* replace
* report
* representation
* represents
* required
* requires
* reserved

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling reset..returns
a7bd87f 
* reset
* resolution
* resources
* respect
* response
* responsibility
* restore
* restriction
* restrictions
* result
* retrieve
* return
* returning
* returns

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling rigid..simplest
f2613cf 
* rigid
* run
* satisfied
* scenarios
* scheme
* screen
* searched
* selected
* selector
* semantics
* sensitive
* separate
* separated
* separator
* separators
* sequel
* service
* session
* setting
* settings
* shortcut
* should
* shouldn't
* shouldn't be
* sideeffect
* sieve
* signature
* significant
* signified
* similar
* simple
* simplest

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling simultaneously..succeeded
1c75cd4 
* simultaneously
* solely
* solution
* some
* somefunction
* sometimes
* source
* spans
* speaking
* specific
* specifically
* specified
* specifies
* specify
* squeak
* squiggly
* statement
* statically
* string
* structure
* style
* submitted
* subsequent
* substitution
* subsumption
* subsystems
* succeed
* succeeded

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling successful..the only value
6343b81 
* successful
* successfully
* such
* suffix
* suitable
* superfluous
* support
* supported
* supports
* suppress
* swallowed
* swapping
* symbol
* synchronize
* syntax
* system
* target
* targeting
* temporary
* the document
* the name
* the only value

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling thingy..unmanaged
11cebd9 
* thingy
* this
* throughout
* tracks
* trailing
* trajectory
* transform
* transformation
* triggered
* triggers
* triples
* trivial
* tuple
* type
* types
* unconfirmed
* uncurried
* uncurrying
* underlying
* unexpected
* uninitialized
* union
* unknown
* unlinked
* unmanaged

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Spelling unnamed..world
d428588 
* unnamed
* unqualified
* unsubscribe
* unsupported
* unverifiability
* useful
* using-fun
* usually
* valid
* validation
* value
* variable
* variations
* verifying
* version
* versions
* vertical
* violated
* virtual
* weirdly
* where
* whether
* whitespace
* widget
* will
* without
* wizard
* workaround
* workarounds
* works
* world

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
quote: with/finally
9222dd0 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
tests: Something wants TypeWhereNamespaceReturnsNull
094b952 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
psfinaki
psfinaki approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay - I think it's ready :) 🚀

vzarytovskii
vzarytovskii requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@vzarytovskii vzarytovskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not go before nullness changes, unless @T-Gro says otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii requested changes

@psfinaki psfinaki psfinaki approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsoref @psfinaki @vzarytovskii