You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The aim of this issues to determine how we can check for malicious links and handle multiple changes to lines or replacing lines in the Contributors.md file uisng which thrid-party tools.
Checking for malicious links
The current PR (#73431) can check the text, but not links. I’ve tested Google Safe Browsing, but it didn’t reliably detect malicious links in my tests. VirusTotal seems more reliable, but I found that it ignored certain websites that should have been flagged as unsafe.
Handling multiple line changes or replacing lines
I'm also open to discussing how to handle PRs with multiple line changes or replaced lines in Contributors.md file. Currently, they stay open with a message to make changes.
What do you think is the best way to handle these PRs? Should we close them and ask the user to create a new PR? Or should we leave them open and allow the user to fix the changes in the existing PR?
Thanks
The text was updated successfully, but these errors were encountered:
Esh07
changed the title
Malicious Link Detection and handling multiple changes to lines or replacing lines in PR.
[Discussion] Malicious Link Detection and handling multiple changes to lines or replacing lines in PR.
Oct 9, 2023
Esh07
changed the title
[Discussion] Malicious Link Detection and handling multiple changes to lines or replacing lines in PR.
[Discussion] Malicious Link Detection and multiple lines changes or replacing lines in PR handle by Github Action script
Nov 5, 2023
Esh07
changed the title
[Discussion] Malicious Link Detection and multiple lines changes or replacing lines in PR handle by Github Action script
[2.0] Malicious Link Detection and multiple lines changes or replacing lines in PR handle by Github Action script
Mar 22, 2024
This issues is linked with PR:
The aim of this issues to determine how we can check for malicious links and handle multiple changes to lines or replacing lines in the Contributors.md file uisng which thrid-party tools.
Checking for malicious links
The current PR (#73431) can check the text, but not links. I’ve tested Google Safe Browsing, but it didn’t reliably detect malicious links in my tests. VirusTotal seems more reliable, but I found that it ignored certain websites that should have been flagged as unsafe.
Handling multiple line changes or replacing lines
I'm also open to discussing how to handle PRs with multiple line changes or replaced lines in
Contributors.md
file. Currently, they stay open with a message to make changes.What do you think is the best way to handle these PRs? Should we close them and ask the user to create a new PR? Or should we leave them open and allow the user to fix the changes in the existing PR?
Thanks
The text was updated successfully, but these errors were encountered: