Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Submit your changes for review" step sometimes doesn't work as intended #82666

Open
Horusateel opened this issue Mar 22, 2024 · 9 comments

Comments

@Horusateel
Copy link
Contributor

When getting to this step, sometimes I indeed found the "Compare & pull request" button as intended, others I didn't.

馃悶 Problem
When applying the exact commands mentioned in the tutorial: git switch -c add-alonzo-church for creating a branch and git commit -m "add alonzo church to Contributors list" for committing, the needed button "Compare & pull request" doesn't appear however many times I refreshed the page.

馃幆 Goal
Refine the instructions so the button appears despite whatever the name of the branch or the commit message provided with it.

馃挕 Possible solutions
I suspect the problem has to do with some keywords in the commit message or the branch name, if absent the button doesn't appear at all.

馃搵 Steps to solve the problem
Perhaps a sequence of trials with various names, branches' names and commit messages to pinpoint the exact words that trigger the button?
I have tried to apply this approach but lost count in the middle.

@himavamsi12
Copy link

can i work on it

@williamalvarezdev
Copy link
Contributor

@Horusateel you need to push.

Have you done git push -u origin add-alonzo-church ?

@Horusateel
Copy link
Contributor Author

@williamalvarezdev
Oh, yes I did. Here's an exact list of the last four commands before I stumbled upon this issue:

  • git switch -c add-alonzo-church
  • git add Contributors.md
  • git commit -m "Add alonzo church to Contributors list"
  • git push -u origin add-alonzo-church

On the contrary, Here's a list of the last four commands before it actually worked and the button indeed appeared for me to complete the guide:

  • git switch -c Horusateel-Horusateel
  • git add Contributors.md
  • git commit -m "Add Horusateel Horusateel to Contributors list"
  • git push -u origin Horusateel-Horusateel

PS: I was testing whether it has something to do with the nature of the commit, since I didn't include a github account link in the alonzo-church trial, but I didn't include a link in the Horusateel-Horusateel trial neither and it worked just fine.

@williamalvarezdev
Copy link
Contributor

Maybe you are missing the .git file. Maybe a simple, delete the file and clone it again might work. The commands you wrote there seems fine.

@Horusateel
Copy link
Contributor Author

@williamalvarezdev

Just tried this out, and the same issue persisted. Don't know how to test whether the .git file exists or not though, how can I test that?

@williamalvarezdev
Copy link
Contributor

Do you get any error messages?

@Horusateel
Copy link
Contributor Author

@williamalvarezdev
No, not at all. Only issue as I described is the button doesn't appear, so I try another username and link and then it worked just fine.
If I may ask, how do professional git users compare and merge? I can imagine this feature of the button appearing automatically is quite new and precarious and more GUI related, there has to be some manual and sure way to compare and merge. I'd very much like to try this method to test it.

@williamalvarezdev
Copy link
Contributor

I use visual studio code. They have a feature where you can compare. Otherwise some plugins with vim also works ok

@STEPHEN07383
Copy link

Have you tried doing git push -u origin add-alonzo-church ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants