Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror package:{coverage|io| node_preamble} on flutter.googlesource.com #145910

Closed
matanlurey opened this issue Mar 28, 2024 · 6 comments
Closed

Mirror package:{coverage|io| node_preamble} on flutter.googlesource.com #145910

matanlurey opened this issue Mar 28, 2024 · 6 comments
Assignees
@keyonghan
Labels
P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team

Comments

@matanlurey
Copy link
Contributor

Type of Request

feature request

Infrastructure Environment

GoB

What is happening?

We would like to use package:test in flutter/engine using entirely vended dependencies (no pub.dev).

There are 3 packages missing (flutter/engine#51726):

I'd like them mirrored in third_pary, similar to https://flutter.googlesource.com/third_party/equatable/.

(I would do this myself, but I can't find any instructions on how to do so)

Steps to reproduce

No response

Expected results

No response
@matanlurey matanlurey added the team-infra Owned by Infrastructure team label Mar 28, 2024
@matanlurey matanlurey mentioned this issue Mar 28, 2024
Merged
@keyonghan keyonghan added P2 Important issues not at the top of the work list triaged-infra Triaged by Infrastructure team labels Mar 28, 2024
@keyonghan keyonghan self-assigned this Mar 28, 2024
@keyonghan
Copy link
Contributor

@matanlurey For each of these repos, do you have a specific commit you want mirror to?

@matanlurey
Copy link
Contributor Author

@matanlurey For each of these repos, do you have a specific commit you want mirror to?

Thanks!

Package Constraint Commit
coverage ^1.15.0 bb0ab721ee4ceef1abfa413d8d6fd46013b583b9
io ^1.0.0 997a6243aad20af4238147d9ec00bf638b9169af
node_preamble ^2.0.0 47245865175929ec452d8058e563c267b64c3d64

@keyonghan
Copy link
Contributor

Coverage is ready: https://flutter.googlesource.com/third_party/coverage/

@keyonghan
Copy link
Contributor

io and node_preamble are ready as well:
https://flutter.googlesource.com/third_party/io
https://flutter.googlesource.com/third_party/node_preamble.dart

Closing as completed.

@matanlurey
Copy link
Contributor Author

Thanks!

@github-actions GitHub Actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@keyonghan keyonghan

Labels
P2 Important issues not at the top of the work list team-infra Owned by Infrastructure team triaged-infra Triaged by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matanlurey @keyonghan