Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter Tool supports multi-platform module config #145641

Closed
wants to merge 4 commits into from

Conversation

mit-73
Copy link

@mit-73 mit-73 commented Mar 23, 2024

Resolves #145640

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 23, 2024
@mit-73 mit-73 force-pushed the multi-plat-module-declaration branch from 5847347 to 42c01d8 Compare March 25, 2024 17:49
@mit-73
Copy link
Author

mit-73 commented Mar 26, 2024

@christopherfujino, @andrewkolos please take a look when you have time

@christopherfujino
Copy link
Member

Thanks for contributing this! As I described in #145640 (comment), although this looks like a reasonable PR for a legitimate problem, I am always nervous about making changes to the schema of Flutter developer-managed configuration files, and so I think we need more discussion and consensus on the issue before we review a particular implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flutter_tools] Supports multi-platform module config
2 participants