New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for theme_extension.1.dart API example. #145819
Add tests for theme_extension.1.dart API example. #145819
Conversation
@Renzo-Olivares, could you please take a look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding this test!
@Renzo-Olivares thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto label is removed for flutter/flutter/145819, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
@Renzo-Olivares @gspencergoog could you please tell me why Google testing is failing? |
@ksokolovskyi Can you try rebasing your branch with |
@Renzo-Olivares still failing =( |
@ksokolovskyi can you try the following, assuming you have
|
78abbde
to
377a2ac
Compare
377a2ac
to
ca1b8f1
Compare
auto label is removed for flutter/flutter/145819, due to - The status or check suite Windows tool_integration_tests_2_6 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto label is removed for flutter/flutter/145819, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
@Renzo-Olivares @gspencergoog @goderbauer thanks for the review! |
flutter/flutter@e868e2b...ac2ca93 2024-04-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from aadf522e3c98 to 4303dc0d7a73 (1 revision) (flutter/flutter#146262) 2024-04-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from c57c8665b4eb to aadf522e3c98 (1 revision) (flutter/flutter#146261) 2024-04-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from ca7596642cfd to c57c8665b4eb (1 revision) (flutter/flutter#146259) 2024-04-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 83c037c449b5 to ca7596642cfd (1 revision) (flutter/flutter#146258) 2024-04-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 614154012e93 to 83c037c449b5 (1 revision) (flutter/flutter#146255) 2024-04-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 41da00ac46bc to 614154012e93 (1 revision) (flutter/flutter#146250) 2024-04-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 18fdcad40332 to 41da00ac46bc (6 revisions) (flutter/flutter#146246) 2024-04-04 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#146245) 2024-04-03 sokolovskyi.konstantin@gmail.com Add tests for theme_extension.1.dart API example. (flutter/flutter#145819) 2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 349608d2b008 to 18fdcad40332 (6 revisions) (flutter/flutter#146240) 2024-04-03 kallentu@google.com Add `missing_code_block_language_in_doc_comment` lint. (flutter/flutter#145354) 2024-04-03 ian@hixie.ch Magnifier cleanup (flutter/flutter#143558) 2024-04-03 34871572+gmackall@users.noreply.github.com Set up Kotlin linting step in ci with ktlint (flutter/flutter#143478) 2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1a9e48ab1c9a to 349608d2b008 (1 revision) (flutter/flutter#146230) 2024-04-03 54558023+keyonghan@users.noreply.github.com Update ownership to GitHub handles (flutter/flutter#146221) 2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from d065763b1a63 to 1a9e48ab1c9a (1 revision) (flutter/flutter#146226) 2024-04-03 103135467+sealesj@users.noreply.github.com Refactor fuchsia_precache (flutter/flutter#145978) 2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from b1c23addaec5 to d065763b1a63 (1 revision) (flutter/flutter#146218) 2024-04-03 31859944+LongCatIsLooong@users.noreply.github.com `computeDryBaseline` for rendering / widgets RenderBoxes (flutter/flutter#146143) 2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7b28ae1d15cb to b1c23addaec5 (1 revision) (flutter/flutter#146214) 2024-04-03 leoafarias@gmail.com Fix TextStyle.lerp() to properly interpolate text shadows (flutter/flutter#145666) 2024-04-03 31859944+LongCatIsLooong@users.noreply.github.com Renderflex cross intrinsic size with baseline alignment (flutter/flutter#146185) 2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 56fa2c33a5f7 to 7b28ae1d15cb (1 revision) (flutter/flutter#146208) 2024-04-03 103135467+sealesj@users.noreply.github.com Refactor customer_testing (flutter/flutter#145911) 2024-04-03 tessertaha@gmail.com Add `DropdownMenu` cursor behavior sample (flutter/flutter#146133) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR contributes to #130459
Description
examples/api/lib/material/theme/theme_extension.1.dart
Pre-launch Checklist
///
).