Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update material_color_utilities package version to latest 0.11.1 #145959

Merged
merged 7 commits into from Apr 3, 2024

Conversation

QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Mar 29, 2024

This PR is to update material_color_utilities package version to the latest. material_color_utilities/scheme/scheme_fruit_salad.dart and material_color_utilities/scheme/scheme_rainbow.dart are exported after version 0.9.0.

Once this PR is merged, we don't need to explicitly import these two files like the change in PR #144805, which breaks some dependencies in Google testing.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos platform-web Web applications specifically f: integration_test The flutter/packages/integration_test plugin labels Mar 29, 2024
@QuncCccccc QuncCccccc marked this pull request as ready for review March 29, 2024 18:14
@@ -9,15 +9,15 @@ dependencies:
sdk: flutter
camera: 0.10.5+9

camera_android: 0.10.8+17 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
camera_android: 0.10.8+18 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking tool integration tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow this is still updated after I pinned this package in update_packages_pins.dart and re-run the update command🧐

@github-actions github-actions bot removed a: internationalization Supporting other languages or locales. (aka i18n) platform-web Web applications specifically labels Mar 29, 2024
@github-actions github-actions bot added a: internationalization Supporting other languages or locales. (aka i18n) platform-web Web applications specifically labels Mar 29, 2024
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ and removed a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos platform-web Web applications specifically f: integration_test The flutter/packages/integration_test plugin labels Mar 29, 2024
@github-actions github-actions bot added platform-web Web applications specifically f: integration_test The flutter/packages/integration_test plugin labels Mar 29, 2024
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Member

integration test failure looked like a timeout, scheduled a retry

@QuncCccccc
Copy link
Contributor Author

integration test failure looked like a timeout, scheduled a retry

Since I still see the timeout error, I rebased master to trigger another rounds of tests, but forget to pull your commit change first. So sorry about that! I just pushed a commit to add the change back to remove the "AUTOGENERATED - ..." line for camera_android!

@christopherfujino
Copy link
Member

Analysis is now failing with:

Warning: pubspec in /b/s/w/ir/x/w/flutter/dev/integration_tests/gradle_deprecated_settings has updated or new dependencies. Please run "flutter update-packages --force-upgrade" to update them correctly.
Warning: one or more pubspecs have invalid dependencies. Please run "flutter update-packages --force-upgrade" to update them correctly.

You'll have to re-run flutter update-packages --force-upgrade to update the checksum at the bottom.

@QuncCccccc
Copy link
Contributor Author

I see. Re-running!

@QuncCccccc
Copy link
Contributor Author

Seems Windows tool_integration_tests_2_6 still failed because of timeout🧐

@christopherfujino
Copy link
Member

re-ran windows tool_integration_test_2_6, i highly doubt that this change caused that timeout.

@christopherfujino
Copy link
Member

re-ran windows tool_integration_test_2_6, i highly doubt that this change caused that timeout.

I was wrong, revving the frontend_server_client DID indeed regress this test: #146164

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2024
@auto-submit auto-submit bot merged commit 69db714 into flutter:master Apr 3, 2024
132 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 3, 2024
Roll Flutter from a418568a6498 to e868e2b3834f (34 revisions)

flutter/flutter@a418568...e868e2b

2024-04-03 65075121+AcarFurkan@users.noreply.github.com Add SegmentedButton expand feature (flutter/flutter#142804)
2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from e36b9b10c36f to 56fa2c33a5f7 (1 revision) (flutter/flutter#146205)
2024-04-03 engine-flutter-autoroll@skia.org Roll Packages from 83f3842 to 0e848fa (3 revisions) (flutter/flutter#146201)
2024-04-03 ian@hixie.ch Enhance ColorScheme.fromSeed with a new `variant` parameter (flutter/flutter#144805)
2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0280de5be276 to e36b9b10c36f (1 revision) (flutter/flutter#146200)
2024-04-03 leroux_bruno@yahoo.fr Fix typos in bottom_sheet.dart (flutter/flutter#146188)
2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 979030d81f8d to 0280de5be276 (2 revisions) (flutter/flutter#146199)
2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from bef3bbe3f74e to 979030d81f8d (1 revision) (flutter/flutter#146186)
2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5fc83bc24b2e to bef3bbe3f74e (1 revision) (flutter/flutter#146183)
2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0da1b2eb370a to 5fc83bc24b2e (1 revision) (flutter/flutter#146180)
2024-04-03 31859944+LongCatIsLooong@users.noreply.github.com Avoid calling `TextPainter.plainText` for simple static text (flutter/flutter#146084)
2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from e603f89844a9 to 0da1b2eb370a (2 revisions) (flutter/flutter#146179)
2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from ef60a95d78c1 to e603f89844a9 (3 revisions) (flutter/flutter#146177)
2024-04-03 31859944+LongCatIsLooong@users.noreply.github.com Fix chip baseline implementation (flutter/flutter#146162)
2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from bb4ec2d7eb39 to ef60a95d78c1 (1 revision) (flutter/flutter#146176)
2024-04-03 sokolovskyi.konstantin@gmail.com Add tests for material_state_mouse_cursor.0.dart API example. (flutter/flutter#145987)
2024-04-03 36861262+QuncCccccc@users.noreply.github.com Update material_color_utilities package version to latest 0.11.1 (flutter/flutter#145959)
2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5f6dec8bd877 to bb4ec2d7eb39 (4 revisions) (flutter/flutter#146169)
2024-04-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5dbcfdc2a456 to 5f6dec8bd877 (1 revision) (flutter/flutter#146163)
2024-04-02 polinach@google.com Dispose FocusNode in tests. (flutter/flutter#146161)
2024-04-02 kallentu@google.com Add `none` language strings to code blocks. (flutter/flutter#146154)
2024-04-02 103135467+sealesj@users.noreply.github.com Refactor docs (flutter/flutter#145998)
2024-04-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from c60b00a20fc3 to 5dbcfdc2a456 (3 revisions) (flutter/flutter#146159)
2024-04-02 fluttergithubbot@gmail.com Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller__timeline_summary to be unflaky (flutter/flutter#140038)
2024-04-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5bf8b94505a4 to c60b00a20fc3 (2 revisions) (flutter/flutter#146157)
2024-04-02 103135467+sealesj@users.noreply.github.com Refactor analyze (flutter/flutter#146138)
2024-04-02 rmolivares@renzo-olivares.dev Implement SelectionArea triple click gestures (flutter/flutter#144563)
2024-04-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6883f7313da0 to 5bf8b94505a4 (2 revisions) (flutter/flutter#146152)
2024-04-02 leroux_bruno@yahoo.fr Fix border color is wrong for a focused and hovered TextField (flutter/flutter#146127)
2024-04-02 goderbauer@google.com Sync lints and enable `annotate_redeclares` (flutter/flutter#146144)
2024-04-02 31859944+LongCatIsLooong@users.noreply.github.com Implements `RenderBox.computeDryBaseline` for material render boxes (flutter/flutter#146027)
2024-04-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 523fc953ebc8 to 6883f7313da0 (2 revisions) (flutter/flutter#146140)
2024-04-02 tessertaha@gmail.com Fix `MenuItemButton` overflow (flutter/flutter#143932)
2024-04-02 engine-flutter-autoroll@skia.org Roll Packages from d5aff19 to 83f3842 (4 revisions) (flutter/flutter#146134)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants