feat(curriculum): add English curriculum block 8.1 sharing progress and accomplishments #54319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naomi-lgbt
reviewed
Apr 8, 2024
...h-for-developers/learn-how-to-share-progress-and-accomplishments/6610056e633ce41466b6c5bc.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Naomi <nhcarrigan@gmail.com>
moT01
reviewed
Apr 26, 2024
...h-for-developers/learn-how-to-share-progress-and-accomplishments/66100326d773b61282509e50.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/_meta/learn-how-to-share-progress-and-accomplishments/meta.json
Outdated
Show resolved
Hide resolved
...h-for-developers/learn-how-to-share-progress-and-accomplishments/66122a393fd32d2a4876ca95.md
Outdated
Show resolved
Hide resolved
curriculum/challenges/_meta/learn-how-to-share-progress-and-accomplishments/meta.json
Outdated
Show resolved
Hide resolved
moT01
approved these changes
May 1, 2024
There was a problem hiding this comment.
I committed my suggestions and a fix to one of the answers.
I didn't go over this with a fine-toothed comb, but I looked over it pretty good. Mainly, I looked at the files - as far as I could tell, the backticks were in all the right places, the questions and fill in the blanks all had the correct answers, and I didn't see any grammar issues.
I would be fine getting this in. We still have to add the videos where we will have another chance to make improvements or catch issues. LGTM @miyaliu666 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.