Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's upgrade the docs to use actions/setup-python@v5 #32653

Merged
merged 2 commits into from Apr 29, 2024
Merged

Let's upgrade the docs to use actions/setup-python@v5 #32653

merged 2 commits into from Apr 29, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 24, 2024 •
edited

Like

https://github.com/actions/setup-python/releases

- actions/setup-python@v4
+ actions/setup-python@v5

https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python#installing-dependencies

@dmitry-shibanov @HarithaVattikuti Your reviews, please.

Why:

See improvements and bug fixes at https://github.com/actions/setup-python/releases

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 24, 2024
@cclauss cclauss changed the title Let's upgrade to actions/setup-python@v5 Let's upgrade the docs to use actions/setup-python@v5 Apr 24, 2024
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Apr 24, 2024
@nguyenalex836
Copy link
Contributor

@cclauss Thanks so much for opening a PR! I'll get this triaged for review ✨

@nguyenalex836 nguyenalex836 removed the waiting for review Issue/PR is waiting for a writer's review label Apr 29, 2024
@nguyenalex836
Copy link
Contributor

@cclauss Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

@github-actions GitHub Actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/automating-builds-and-tests/building-and-testing-python.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
from reusable
actions/deployment/deploying-to-your-cloud-provider/deploying-to-azure/deploying-python-to-azure-app-service.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
from reusable
actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-pypi.md fpt
ghec
 fpt
ghec
 from reusable
actions/migrating-to-github-actions/manually-migrating-to-github-actions/migrating-from-azure-pipelines-to-github-actions.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
from reusable
actions/migrating-to-github-actions/manually-migrating-to-github-actions/migrating-from-travis-ci-to-github-actions.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
from reusable
contributing/style-guide-and-content-model/style-guide.md fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.12 3.11 3.10 3.9
from reusable

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Apr 29, 2024
Merged via the queue into github:main with commit a3d419f Apr 29, 2024
40 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@cclauss cclauss deleted the patch-2 branch April 29, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenalex836 nguyenalex836 nguyenalex836 approved these changes

Assignees
No one assigned
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cclauss @nguyenalex836