Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "not used" params in BBS migrations #1012

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

synthead
Copy link
Collaborator

@synthead synthead commented Jun 1, 2023

Bitbucket Server migrations are archive-only and BBS instances are assumed to be unreachable from the internet. Therefore, Octoshift will never reach out to source instances, and a source PAT is not required. Additionally, BBS migration archives are only single archives that we move using the gitArchiveUrl GraphQL field for startMigration mutations. Therefore, we never use metadataArchiveUrl field.

We have updated the public GraphQL interface to make these two parameters optional. Prior to this, we added filler "not used" values for accessToken and metadataArchiveUrl to satisfy the GraphQL request requirements. These ignored "filler" values are not necessary anymore, so this PR removes them! ✨

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Unit Test Results

780 tests   778 ✔️  23s ⏱️
    1 suites      0 💤
    1 files        2

For more details on these failures, see this check.

Results for commit f9a5929.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Code Coverage

Package Line Rate Branch Rate Complexity Health
bbs2gh 79% 75% 573
ado2gh 84% 82% 617
gei 83% 79% 652
Octoshift 85% 75% 1168
Summary 84% (6490 / 7765) 77% (1572 / 2042) 3010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants