Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check current translated files #3072

Closed
wants to merge 5 commits into from
Closed

check current translated files #3072

wants to merge 5 commits into from

Conversation

pipobarari
Copy link

@pipobarari pipobarari commented Aug 19, 2023

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


I translated some part to Italian, but I wanted somebody else to check my progress, there are the folders and respective files for it = italian.

Regards

@pipobarari pipobarari requested a review from a team as a code owner August 19, 2023 03:05
@pipobarari pipobarari temporarily deployed to Pages Preview August 19, 2023 03:06 — with GitHub Actions Inactive
@Dispatchermillie

This comment was marked as spam.

@ahpook
Copy link
Contributor

ahpook commented Aug 25, 2023

This is great, thank you @pipobarari for the translation and good metadata.

Do you know another Italian-speaking user who can check these translations? I watch bicycle racing with commentary in Italian but that does not help much here! 😸

Are you planning to add more files / commits or should I merge this as it is today?

@pipobarari
Copy link
Author

Im not able to continue translating the remaining files unlucky, and I don't know any other Italian who can help us either unfortunately.

Thanks for answering!

@RhondaRay

This comment was marked as spam.

@Livepiggie Livepiggie mentioned this pull request Sep 1, 2023
2 tasks
@ahpook
Copy link
Contributor

ahpook commented Sep 2, 2023

I'll go ahead and merge this to get your good work out there, hopefully other people will pick it up in the future. Thank you!

Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in the absence of another Italian speaker to review I'm going to go ahead and merge.

@jacopobr
Copy link

Hello @ahpook. I am a native Italian speaker and will check the translations before the merge. Or you could merge and I'll open a new branch to translate what is missing. What do you prefer?

@underwoo16 underwoo16 temporarily deployed to Pages Preview September 22, 2023 17:18 — with GitHub Actions Inactive
@zkoppert
Copy link
Member

@jacopobr I am planning to merge this in. If you could open another branch/pull request with any revisions that would be much appreciated!

@zkoppert
Copy link
Member

@pipobarari It looks like there are some errors coming up in the test that looks for valid links. Can you check the results and see if that is something you can correct?

@jacopobr
Copy link

Hello @zkoppert, as I was taking as example the pull requests on fork for German translation mentioned in the translation.md file, I opened two PRs to @pipobarari's fork since he was the one starting the translation.
Do you still prefer me to open new a branch/pr?

@zkoppert
Copy link
Member

@jacopobr Oh ok. Feel free to contribute to this branch in that case.

@zkoppert zkoppert added the work in progress work in progress label Sep 29, 2023
@Maduraprasa

This comment was marked as spam.

@0983165121

This comment was marked as spam.

@LizzyOrji123
Copy link
Contributor

The part i love most about your work is how beautifully crafted your meta tag section is.

@github github deleted a comment from sa-ko4969 Oct 26, 2023
Ptyrone489

This comment was marked as spam.

Dossi1

This comment was marked as spam.

yungeeng

This comment was marked as spam.

@LizzyOrji123
Copy link
Contributor

Every thing is confusing

I would appreciate a more constructive feedback from you.
A project forked and contributed by a professional deserves a professional feedback from you. I am waiting for your constructive feedback stating the exact parts that are confusing to you.
Thank you.

@LizzyOrji123
Copy link
Contributor

Label for love octicon

Hi,
Could you be more detailed with what you wrote?

@ahpook
Copy link
Contributor

ahpook commented Jan 7, 2024

@LizzyOrji123 these are just spam comments, don't worry about it - but thank you for replying. We get a lot of fake comments/prs on this project from accounts that are trying to boost reputation so they can be sold for more money.

@omarwbassam

This comment was marked as spam.

Rudyrude81

This comment was marked as spam.

Avalir1996

This comment was marked as spam.

Ketchaiyo982

This comment was marked as spam.

trevpeace

This comment was marked as spam.

JASoN-ZiloY

This comment was marked as spam.

@github github deleted a comment Feb 22, 2024
@github github deleted a comment Feb 22, 2024
@trevpeace

This comment was marked as spam.

@trevpeace

This comment was marked as spam.

Copy link

@mahdiansyah1 mahdiansyah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_articles/it/best-practices.md

@JoseRuelas1990
Copy link

I can trasleite to spanish

  • [ ]

Hasmuni5757

This comment was marked as spam.

@KissMyPixel

This comment was marked as spam.

@KissMyPixel

This comment was marked as spam.

Diamondb32

This comment was marked as spam.

@JASoN-ZiloY

This comment was marked as spam.

@pipobarari pipobarari closed this Apr 4, 2024
auto-merge was automatically disabled April 4, 2024 04:00

Pull request was closed

@github github locked as spam and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
work in progress work in progress
Projects
None yet