Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect deletion of slides without corresponding book.toml entry #1417

Open
djmitche opened this issue Oct 23, 2023 · 1 comment
Open

Detect deletion of slides without corresponding book.toml entry #1417

djmitche opened this issue Oct 23, 2023 · 1 comment
Assignees
@Gourav2609
Labels
good first issue Good for newcomers

Comments

@djmitche
Copy link
Collaborator

We have occasionally deleted a file without adding an entry to book.toml, leaving existing links to that file with a 404 error page.

It shouldn't be too hard to detect, in the GitHub actions, that a file has been deleted, and verify that there is an entry in book.toml for the .html filename that it would have produced.
@djmitche djmitche added the good first issue Good for newcomers label Oct 23, 2023
@Gourav2609
Copy link
Contributor

I have opened a PR regarding this .. Please check this out

@Gourav2609 Gourav2609 mentioned this issue Oct 25, 2023
Open
@djmitche djmitche mentioned this issue Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gourav2609 Gourav2609

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djmitche @Gourav2609