You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The approved label is added incorrectly when there is one approving review followed by one changes requested review.
Steps to reproduce
Set up branch protections to require 1 (might not be relevant?)
Request 2 reviews
First reviewer approves the changes (should go to PR: partially-approved, which occurs)
Second reviewer requests changes
Pull Request URL
Private repo unfortunately
What is the current bug behavior?
PR: reviewed-approved label is added
What is the expected correct behavior?
PR: reviewed-changes-requested label is added
Relevant logs and/or screenshots
Possible fixes
(If you have any idea to solve the problem, please help us.)
Most likely related to #223. I'm willing to take a crack at a PR in the future, but a little busy at the moment.
The text was updated successfully, but these errors were encountered:
Summary
The
approvedlabel is added incorrectly when there is one approving review followed by one changes requested review.Steps to reproduce
PR: partially-approved, which occurs)Pull Request URL
Private repo unfortunately
What is the current bug behavior?
PR: reviewed-approvedlabel is addedWhat is the expected correct behavior?
PR: reviewed-changes-requestedlabel is addedRelevant logs and/or screenshots
Possible fixes
(If you have any idea to solve the problem, please help us.)
Most likely related to #223. I'm willing to take a crack at a PR in the future, but a little busy at the moment.
The text was updated successfully, but these errors were encountered: