Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen "partially-approved" conditions #246

Open
maestromac opened this issue Jul 31, 2020 · 3 comments
Open

Loosen "partially-approved" conditions #246

maestromac opened this issue Jul 31, 2020 · 3 comments

Comments

@maestromac
Copy link

maestromac commented Jul 31, 2020 •
edited

Is your feature request related to a problem? Please describe.
We would like to see the tag partially-approved only when branch protection's request is not met.

Right now, the code also checks if everyone requested has approved it. The combination of CODEOWNER file and our flow, we tend to over-request for reviews, making it impossible for some PR to attain the proper approved tag.

Describe the solution you'd like
I would like to remove the second portion of this code, numRequestedReviewsRemaining > 0. If this is approved and people agree with this, I can submit PR to update this feature.

Describe alternatives you've considered
Offer it as a configuration option.

Additional context
I would also like to hear @allout58 's thoughts on this since this is their feature.
@allout58
Copy link
Contributor

allout58 commented Aug 1, 2020

That makes sense. If there is a way to make it configurable, that would be nice (still would have to pick one to be the default, but that's not too big of a deal).
My original thought was to prevent it from being "approved" if you had requested a review from someone you don't normally request. Or for odd cases like our usual flow where we have two team leads (both CODEOWNERS) and want to require both to approve a PR from our junior developers, but don't want to require 2 reviews on the whole branch so he and I can just review each other without getting others involved.

@sotayamashita
Copy link
Member

I am investigating now.

@sotayamashita
Copy link
Member

@maestromac
I have not yet been able to make time to investigate. I would appreciate it if you create a pull request to fix the issue.
Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sotayamashita @allout58 @maestromac