Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make labels configurable. #88

Open
nesl247 opened this issue Aug 6, 2018 · 4 comments
Open

Make labels configurable. #88

nesl247 opened this issue Aug 6, 2018 · 4 comments
Labels
enhancement hacktoberfest help wanted

Comments

@nesl247
Copy link
Contributor

nesl247 commented Aug 6, 2018 •
edited

Summary

Please add the ability to customize the labels that will be used. PR: unreviewed, PR: review-approved and PR: reviewed-changes-requested doesn't match our style. While we can obviously fork the app and make the changes, it would be great to make them configurable.

If this feature is done, I would use probot-config to allow for a .github/pr-triage.yml file.

In order to keep the labels under control, if this is implemented, it would be great if it would automatically migrate the existing label names. Do a check to see if the original name exists, and then replace it with the configured name. This way we don't have a ton of PRs that don't have the correct label.
@sotayamashita
Copy link
Member

sotayamashita commented Aug 8, 2018 •
edited

@nesl247

Sorry not to replay quickly. I understand your request. My friends also say same thing 😄 so I am implementing the feature with https://github.com/probot/probot-config on https://github.com/pr-triage/app/tree/feat/use-probot-config-instead

if this is implemented, it would be great if it would automatically migrate the existing label names

Let me think. I will replay the message about it later.

test

@sotayamashita sotayamashita self-assigned this Aug 8, 2018
@sotayamashita
Copy link
Member

sotayamashita commented Aug 29, 2018 •
edited

@nesl247

I am sorry not to begin this job but I am too busy right now. You may be also busy, but I would appreciate if you could contribute it. Thanks in advance. 🙇

@nesl247
Copy link
Contributor Author

nesl247 commented Aug 29, 2018

@sotayamashita Nothing to apologize for. I'll see if I have some time soon to look into this.

@sotayamashita sotayamashita removed their assignment Sep 6, 2018
@maestromac maestromac mentioned this issue Jan 22, 2020
Closed
@ssfxate
Copy link

ssfxate commented Mar 22, 2021

Hey. Is it still going to be released? I'm really need it, 'cause I like the app, but can't apply it to my repository due to fixed tags' names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nesl247 @sotayamashita @ssfxate