Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autodetect terminal width or add option to --progress to specify width #7794

Open
eharris opened this issue Apr 22, 2024 · 2 comments
Open

Autodetect terminal width or add option to --progress to specify width #7794

eharris opened this issue Apr 22, 2024 · 2 comments

Comments

@eharris
Copy link
Contributor

eharris commented Apr 22, 2024

What is your current rclone version (output from rclone version)?

rclone v1.66.0-DEV

  • os/version: debian 12.5 (64 bit)
  • os/kernel: 6.1.0-20-amd64 (x86_64)
  • os/type: linux
  • os/arch: amd64
  • go/version: go1.21.8
  • go/linking: dynamic
  • go/tags: cmount

What problem are you are trying to solve?

The rclone --progress display assumes a very narrow (80 character) terminal width, and formats the display for that.
Consequently, the display of longer path/filenames are often truncated too much to be useful.

How do you think rclone should be changed to solve that?

Either auto-detect the real terminal width (which is often more than 80 characters these days), or add an optional parameter to -P/--progress to specify the desired display width.

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.
@albertony
Copy link
Contributor

The path truncation is configurable: https://rclone.org/docs/#stats-file-name-length-integer

Adding --stats-file-name-length 0 may give you closer to acceptable results?
Its not adapting to the actual terminal size, though, so I agree that is a potential improvement.

@eharris
Copy link
Contributor Author

eharris commented Apr 23, 2024

@albertony Thanks for that pointer, that does help. I had been searching for things relating to progress or terminal width and found nothing, and the stats settings seemed to be related to logging, not progress. And the progress docs didn't have a pointer to the --stats-* settings. Perhaps I'll create a PR to add a reference to the stats settings to the --progress docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@albertony @eharris