New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quick-reactions
- New feature
#7247
base: main
Are you sure you want to change the base?
Conversation
Love this. I'm concerned that it will break quickly and painfully, but if it's solid enough I'll just merge it anyway, because we can deal with that via hotfixes. The concern at the moment is that Refined GitHub is seeing some serious slowdowns in issues/PRs at the moment so I might not be able to merge this or add new features for a while :( |
Thanks for taking a look! Let me know if I can do anything to get this into a state you're comfortable shipping. 💪 |
It's not an issue with this PR, but rather with Refined GitHub itself. I can merge it once I figure out the root cause of this: because those features also use the selector observer, so I'm afraid that that's what's causing the slow-downs. |
{ | ||
"id": "quick-reactions", | ||
"description": "Shows a reaction optimistically", | ||
"screenshot": "https://user-images.githubusercontent.com/1402241/236628453-8b646178-b838-44a3-9541-0a9b5f54a84a.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just commenting for an issue I'm opening.
Will edit comment with issue number.
EDIT:
issue number: #7311
Optimistically applies reactions instead of waiting for a slow network request to finish.
This should work anywhere you can react to something on GitHub. Reactions are added, updated and removed immediately. New reactions are inserted in the correct place and will not jump around when the new markup comes in.
Test URLs
Screenshot