Onboarding PRs are not updated according to `onboardingConfig` changes #28659

amezin · 2024-04-25T15:42:00Z

amezin
Apr 25, 2024

What would you like help with?

I think I found a bug

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Bitbucket Server, Docker image ghcr.io/renovatebot/renovate:37.320.1-full

Please tell us more about your question or problem

I extended autodiscoverFilter filter, Renovate created an onboarding PR
I've noticed that the default config doesn't include 'extends': ['config:recommended'], so I've added onboardingConfig to config.js
Re-ran Renovate - onboarding PR not updated, still missing 'extends': ['config:recommended']. Setting RENOVATE_CHECKED_BRANCHES to the onboarding branch name didn't help either. But after the onboarding PR and branch were deleted, Renovate created a new onboarding PR, which included 'extends': ['config:recommended'].

Logs (if relevant)

Logs

DEBUG: config file not found (repository=MC/web-installer)

DEBUG: Found no closed onboarding PR (repository=MC/web-installer)

DEBUG: Repo is not onboarded (repository=MC/web-installer)

DEBUG: getBranchPr(task-renovate-configure) (repository=MC/web-installer)

DEBUG: findPr(task-renovate-configure, "undefined", "open") (repository=MC/web-installer)

DEBUG: getPrList() (repository=MC/web-installer)

DEBUG: returning cached PR list (repository=MC/web-installer)

DEBUG: Found PR #698 (repository=MC/web-installer)

DEBUG: getPr(698) (repository=MC/web-installer)

DEBUG: Onboarding PR already exists (repository=MC/web-installer)

DEBUG: branch.isModified(): using git to calculate (repository=MC/web-installer)

DEBUG: branch.isModified() = false (repository=MC/web-installer)

DEBUG: setCachedModifiedResult(): Branch cache not present (repository=MC/web-installer)

DEBUG: Checking if onboarding branch needs rebasing (repository=MC/web-installer)

DEBUG: Skipping rebase as bitbucket-server does not support html comments (repository=MC/web-installer)

DEBUG: getPr(698) (repository=MC/web-installer)

DEBUG: Merge onboarding branch in default branch (repository=MC/web-installer)

DEBUG: ensureOnboardingPr() (repository=MC/web-installer)

DEBUG: getBranchPr(task-renovate-configure) (repository=MC/web-installer)

DEBUG: findPr(task-renovate-configure, "undefined", "open") (repository=MC/web-installer)

DEBUG: getPrList() (repository=MC/web-installer)

DEBUG: returning cached PR list (repository=MC/web-installer)

DEBUG: Found PR #698 (repository=MC/web-installer)

DEBUG: getPr(698) (repository=MC/web-installer)

DEBUG: Filling in onboarding PR template (repository=MC/web-installer)

DEBUG: getConfigDesc() (repository=MC/web-installer)

DEBUG: getDescriptionArray() (repository=MC/web-installer)

DEBUG: getScheduleDesc() (repository=MC/web-installer)

DEBUG: No schedule (repository=MC/web-installer)

DEBUG: No config description found (repository=MC/web-installer)

DEBUG: getPrList() (repository=MC/web-installer)

DEBUG: massageMarkdown(Welcome to [Renovate](https://github.com/renovatebot/renovate)! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.) (repository=MC/web-installer)

DEBUG: Found open onboarding PR (repository=MC/web-installer)

DEBUG: updatePr(698, title=Configure Renovate) (repository=MC/web-installer)

DEBUG: getPr(698) (repository=MC/web-installer)

 INFO: Onboarding PR updated (repository=MC/web-installer)
       "pr": 698

rarkins · 2024-04-29T09:36:38Z

rarkins
Apr 29, 2024
Maintainer

I'm not able to reproduce this. Whenever I change onboardingConfig in config.js, Renovate pushes the changes to the onboarding PR. Here's the log at the time:

DEBUG: onboarding config (repository=renovate-reproductions/onboarding6)
       "config": {
         "$schema": "https://docs.renovatebot.com/renovate-schema.json",
         "extends": ["config:best-practices"]
       }
DEBUG: Rebasing onboarding branch (repository=renovate-reproductions/onboarding6)
       "previousConfigHash": "94693a990c975907e7f13da3309b9d56ba02b3983519b41786edf5cf031e457c",
       "currentConfigHash": "55dfe6c56b39d1803cd815da40683bcba49c147ccd1888b0273d53c80fdb443c"
DEBUG: Preparing files for committing to branch renovate/configure (repository=renovate-reproductions/onboarding6)
DEBUG: Setting git author name: Renovate Testing (repository=renovate-reproductions/onboarding6)
DEBUG: Setting git author email: renovate-tests@redgc.com (repository=renovate-reproductions/onboarding6)
DEBUG: git commit (repository=renovate-reproductions/onboarding6)
       "deletedFiles": [],
       "ignoredFiles": [],
       "result": {
         "author": null,
         "branch": "renovate/configure",
         "commit": "9e4765571328aeb6da2e8c42becece386fdb2a56",
         "root": false,
         "summary": {"changes": 1, "insertions": 6, "deletions": 0}
       }
DEBUG: Pushing refSpec renovate/configure:renovate/configure (repository=renovate-reproductions/onboarding6)
DEBUG: git push (repository=renovate-reproductions/onboarding6)
       "result": {
         "pushed": [],
         "ref": {"local": "refs/remotes/origin/renovate/configure"},
         "remoteMessages": {"all": []}
       }

Do you have the repository cache enabled?

2 replies

amezin May 1, 2024
Author

Yes, I have it enabled

rarkins May 5, 2024
Maintainer

I'm still not able to reproduce, even with caching enabled

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Onboarding PRs are not updated according to `onboardingConfig` changes #28659

{{title}}

Replies: 1 comment 2 replies

{{title}}

{{title}}

{{title}}

Select a reply

Onboarding PRs are not updated according to onboardingConfig changes #28659

amezin Apr 25, 2024

What would you like help with?

How are you running Renovate?

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Please tell us more about your question or problem

Logs (if relevant)

Replies: 1 comment · 2 replies

rarkins Apr 29, 2024 Maintainer

amezin May 1, 2024 Author

rarkins May 5, 2024 Maintainer

Onboarding PRs are not updated according to `onboardingConfig` changes #28659

amezin
Apr 25, 2024

Replies: 1 comment 2 replies

rarkins
Apr 29, 2024
Maintainer

amezin May 1, 2024
Author

rarkins May 5, 2024
Maintainer