Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace tinymce with novel-svelte #110

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

rotimi-best
Copy link
Owner

@rotimi-best rotimi-best commented Dec 18, 2023

What does this PR do?

The goal of this PR is to replace tinymce with novel-svelte, a notion like editor for a much better writing experience.

There are a couple of features that I need which don't exist in the original repo. I have created PR's to add them into the repo:

  1. expose the editor instance TGlide/novel-svelte#11
  2. add disableLocalStorage option TGlide/novel-svelte#10

Checklist

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Open any course
  • Open a lesson
  • Click Edit
  • Start typing in notion like editor.

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the ClassroomIO Docs if changes were necessary

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 5:55pm
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 5:55pm
landingpage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 5:55pm

Copy link

github-actions bot commented Dec 18, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@rotimi-best
Copy link
Owner Author

Current update of the editor:

https://jam.dev/c/ee238960-fd61-44c3-b909-5a8a31e861a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant