Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding gRPC apis functionality #318

Open
JayKaku opened this issue Nov 10, 2023 · 4 comments
Open

Adding gRPC apis functionality #318

JayKaku opened this issue Nov 10, 2023 · 4 comments

Comments

@JayKaku
Copy link
Contributor

JayKaku commented Nov 10, 2023

As there is already a server written for gRPC, gRPC apis (replicating HTTP ones) would be a valuable addition to the suite as a whole. I would like to discuss further on this and contribute. Thanks.
@Rachitmehrotra
Copy link

@stefanprodan we need grpc server for our use case is it possible for you to allow him to raise PR.

@stefanprodan
Copy link
Owner

Sure let's do first version and echo to see how it goes.

@JayKaku JayKaku mentioned this issue Nov 18, 2023
Closed
@JayKaku
Copy link
Contributor Author

JayKaku commented Nov 20, 2023

#322 here is the new PR with 2 commits as you suggested, the issue with the previous one being the git history was very entangled

@stefanprodan
Copy link
Owner

In #322 we covered the following APIs:

  • echo
  • version
  • panic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stefanprodan @Rachitmehrotra @JayKaku