[cookies] Support Firefox containers JSON version 5 #9655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Firefox has a new version of the containers.json that needs to be read to extract the correct cookies. E.g. the follow command currently fails even though the default container user-context-personal exists:
This is because version 5 of the contains.json format has the member
l10nId
(note the smalld
) with the formatuser-context-${name}
, where version 4 hadl10nID
withuserContext${name}.label
. Compare the version 4 from an old issue comment on this repo with the following version 5:This PR fixes this by still supporting version 4, but in addition supporting version 5 by testing one extra regular expression.
I was unable to find any documentation of the different versions of containers.json, I assume Firefox sees this as an internal detail only and not part of any public API.
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?