Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: sensor: ams_as5600: Fix calculation of fractional part #70142

Closed
yashi opened this issue Mar 13, 2024 · 4 comments
Closed

drivers: sensor: ams_as5600: Fix calculation of fractional part #70142

yashi opened this issue Mar 13, 2024 · 4 comments
Assignees
Labels
area: Sensors Sensors backport v3.4-branch Backport to the v3.4-branch backport v3.5-branch Backport to the v3.5-branch backport v3.6-branch Request backport to the v3.6-branch Backport Backport PR and backport failure issues bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@yashi
Copy link
Collaborator

yashi commented Mar 13, 2024

This is backport of #67590 to v3.4, v3.5, and v3.6. drivers/sensor/ams_as5600/ams_as5600.c is introduced before v3.3. #67590 is the first change to the file.

@yashi yashi added bug The issue is a bug, or the PR is fixing a bug Backport Backport PR and backport failure issues backport v3.6-branch Request backport to the v3.6-branch labels Mar 13, 2024
@nordicjm
Copy link
Collaborator

You only create 1 issue and use it for backporting

@yashi
Copy link
Collaborator Author

yashi commented Mar 13, 2024

oops. Thanks, @nordicjm! I'll keep this and close others for all backports.

BTW, do you have a pointer to a doc how to request backporting? search https://docs.zephyrproject.org/ but didn't find. All I found was https://github.com/zephyrproject-rtos/zephyr/wiki/Zephyr-Change-Control-Board-(CCB)

@nordicjm
Copy link
Collaborator

Seems not, all there is is https://docs.zephyrproject.org/latest/project/dev_env_and_tools.html

Backport
The PR is a backport or should be backported.

But essentially you create an issue without any labels, then on your main PR add the backport labels (either before or after it has been merged) then the bot will automatically create the backport PRs, if there are no merge conflicts then you just edit the bot's posts to have Fixes #<bug_id> and re-run the compliance check, if there are merge conflicts then you need to check out the specific branch that was created and fix them

@aescolar aescolar added the priority: low Low impact/importance bug label Mar 19, 2024
@aescolar
Copy link
Member

Closing as it seems to be merged in all old branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sensors Sensors backport v3.4-branch Backport to the v3.4-branch backport v3.5-branch Backport to the v3.5-branch backport v3.6-branch Request backport to the v3.6-branch Backport Backport PR and backport failure issues bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

5 participants