Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chown to use primary group of user for group name #3577

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kmcfate
Copy link

@kmcfate kmcfate commented Sep 9, 2022

Sometimes there is a 'users' group, not a group per user. This makes it use primary group of user, not the explicit user name for group name.

@joolswills
Copy link
Member

Thanks.

Yeah, it was always designed around there being a group with the same name (as RetroPie originated on an OS where this was the default). The changes look good, but I will need to give it a test etc.

@joolswills
Copy link
Member

After a discussion with some other developers, we would prefer this to be implemented with a variable $group. eg doing group=$(id -ng) in retropie_packages.sh and then doing chown $user:$group. Primarily because it's a clearer more well known syntax than leaving the group name out of the chown.

I'm happy if you want to change this PR to implement it like that, or if you prefer I can make the changes. Thanks again.

@laiti
Copy link

laiti commented Dec 24, 2022

@joolswills I made a pull request following that guideline.

@joolswills
Copy link
Member

Going to do this with some variable name changes in addition. Sorry for delays but will look at this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants