Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Pocketbase datasource plugin implementation #9145

Merged
merged 4 commits into from Apr 1, 2024

Conversation

blank0537
Copy link
Contributor

@blank0537 blank0537 commented Mar 20, 2024

Closes #7338
PR has the feature implementation of Pocketbase as data source plugin.

Operations that can be performed:

  1. List Records: It will fetch all records from a collection. It returns array of objects and each object is record. It has sorting and filter functionality.
    7338

  2. Get Record: It will fetch record from a collection based on provided record Id.
    7338-get-record

  3. Add Record: It will add record of collection. Appropriate json object needs to be passed in body with valid collection keys.
    7338-add

  4. Update Record: It will update record of collection based on given record id. Appropriate json object needs to be passed in body with valid collection keys.
    7338-update

  5. Delete Record: It will delete record of collection based on given record id.
    7338-delete

Copy link

Copy link
Collaborator

@akshaysasidrn akshaysasidrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blank0537 Have left some comments, please check.

marketplace/plugins/pocketbase/lib/manifest.json Outdated Show resolved Hide resolved
marketplace/plugins/pocketbase/lib/manifest.json Outdated Show resolved Hide resolved
marketplace/plugins/pocketbase/lib/manifest.json Outdated Show resolved Hide resolved
marketplace/plugins/pocketbase/lib/index.ts Show resolved Hide resolved
marketplace/plugins/pocketbase/lib/index.ts Outdated Show resolved Hide resolved
marketplace/plugins/pocketbase/lib/operations.json Outdated Show resolved Hide resolved
@blank0537
Copy link
Contributor Author

blank0537 commented Mar 28, 2024

@akshaysasidrn Resolved all above comments and also implemented common component for this kind of filter and sorts(these are in supabase but not as common)
So from next time onwards when there is requirement for these components then in operation.json file we need to pass type value as "filters" to load filter condition component and "sorts" for sort condition component.

Copy link
Collaborator

@akshaysasidrn akshaysasidrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put some in nitpicks. Looks great otherwise.

Please resolve the merge conflicts.

server/src/assets/marketplace/plugins.json Outdated Show resolved Hide resolved
server/src/assets/marketplace/plugins.json Outdated Show resolved Hide resolved
@blank0537
Copy link
Contributor Author

Put some in nitpicks. Looks great otherwise.

Please resolve the merge conflicts.

@akshaysasidrn resolved nitpicks and conflicts.

@akshaysasidrn akshaysasidrn changed the base branch from develop to release/community April 1, 2024 06:18
@akshaysasidrn akshaysasidrn changed the base branch from release/community to release/plugins April 1, 2024 06:18
@akshaysasidrn akshaysasidrn changed the base branch from release/plugins to develop April 1, 2024 06:19
@akshaysasidrn akshaysasidrn merged commit cf5a9f7 into ToolJet:develop Apr 1, 2024
7 checks passed
@akshaysasidrn
Copy link
Collaborator

Thank you for your contribution @blank0537! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PocketBase to the datasource
3 participants