Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec for #1984 - Apps & Packages #2204

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

joadoumie
Copy link
Contributor

@joadoumie joadoumie commented Jan 31, 2024

Summary of the pull request

This is the spec for #1984 - we will likely need to revisit and update certain aspects, but overall it outlines the key features and expected requirements for this functionality.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@krschau krschau added the Spec-In Review Specs ready for review. Only the spec author should remove this label and merge when ready. label Jan 31, 2024
Copy link
Contributor

@krschau krschau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address differing behavior between msstore and winget packages.

#### Job-to-be-done

1. Update a package to the latest version
2. Roll back to a previous version of a package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you want dependencies to be handled when rolling back? If Package Bv3.0 depends on Package Av2.0. Package A is rolled back to v1.0. What should happen to package B? Should it roll back? Should the roll back terminate with an unsuccessful message because other packages need to be rolled back?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really interesting edge case - good call out. Let's see what works best for various workflows. My gut says we should have a design that alerts the user that the package they intend to roll-back has dependencies and allow the user to determine yes/no to continue or not.

@joadoumie
Copy link
Contributor Author

I've made the updates to explicitly state that the msstore source packages will only support updating to the latest version and uninstall.

I think this spec is in a pretty good state now.

| --- | -------- | -------- |
| 1 | A user can view application name, publisher, size, version, and source | 0 |
| 2 | A user can switch between different versions of a package | 0 |
| 3 | A user can select multiple applications at a time to perform bulk actions like update or uninstall | 0 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the user clicks for an update, is the update going to default to "Silent" experience or "Silent With Progress" or an "Interactive" one? Some packages do not behave well in a silent installation (can default to installing in another location, may overwrite existing user configs) but expose the ability to select those options in an interactive install/update. How would the install modes be honored in a "bulk update" scenario? Can it be possible to set a preference only for specific packages that a user knows do not behave well in a certain install mode?

I think there should be a way to specify an install mode for an install/update and set a default install mode in user settings (where DevHome would try to honor the install mode if the installer supports it). There should be ways to offer a better UX if an installer doesn't support one of these modes. For this, we may need to populate winget manifests better with InstalModes: field. Not sure if this is within the scope of this spec / future consideration but wanted to call this out in any case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spec-In Review Specs ready for review. Only the spec author should remove this label and merge when ready.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants