Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push: avoid overwriting tags on push #2020

Merged
merged 1 commit into from Mar 16, 2021
Merged

Conversation

tonistiigi
Copy link
Member

fix #2004

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
Copy link
Member Author

@Vlaaaaaaad please check if this fixes your ECR case.

docker buildx build -t moby/buildkit:pr2020 --load "git://github.com/moby/buildkit#pull/2020/head" && docker buildx create --driver-opt image=moby/buildkit:pr2020 --use

@Vlaaaaaaad
Copy link

@tonistiigi I just copy/pasted that command, after setting up and before building and pushing the image. No idea if that was what I was supposed to do, or if I was supposed to translate that into parameters for the GitHub Action.

It does indeed seem to have fixed the issue as the image push was successful, so I think we can celebrate: https://github.com/Vlaaaaaaad/ecr-dual-arch-immutable-buildkit-bug/pull/3/checks?check_run_id=2112605412#step:9:472 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure pushing multi-arch images to Private AWS ECR with tag immutability enabled
3 participants