Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kit): allow finding virtual files with resolvePath and findPath #26465

Merged
merged 15 commits into from Apr 19, 2024
Merged

feat(kit): allow finding virtual files with resolvePath and findPath #26465

merged 15 commits into from Apr 19, 2024

Conversation

ineshbose
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I have extended the functionality of findPath to check within Nuxt templates if provided the option; these templates may be in virtual files or may have not been written to the file system yet. Also added a basic test.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Mar 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe requested a review from manniL April 18, 2024 19:12
@danielroe danielroe changed the title feat(kit): findPath considers templates too feat(kit): allow finding virtual files with resolvePath and findPath utils Apr 18, 2024
@danielroe danielroe changed the title feat(kit): allow finding virtual files with resolvePath and findPath utils feat(kit): allow finding virtual files with resolvePath and findPath Apr 18, 2024
@danielroe danielroe merged commit 3e610df into nuxt:main Apr 19, 2024
36 checks passed
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manniL manniL manniL approved these changes

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
3.x enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ineshbose @manniL @danielroe