New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kit): allow finding virtual files with resolvePath
and findPath
#26465
Merged
+74
β2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
ineshbose
force-pushed
the
feat/find-path-vfs
branch
from
March 24, 2024 14:29
a9d8a19
to
5f3b344
Compare
danielroe
approved these changes
Apr 18, 2024
manniL
approved these changes
Apr 18, 2024
danielroe
changed the title
feat(kit): findPath considers templates too
feat(kit): allow finding virtual files with Apr 18, 2024
resolvePath
and findPath
utils
danielroe
changed the title
feat(kit): allow finding virtual files with
feat(kit): allow finding virtual files with Apr 18, 2024
resolvePath
and findPath
utilsresolvePath
and findPath
manniL
approved these changes
Apr 19, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
I have extended the functionality of
findPath
to check within Nuxt templates if provided the option; these templates may be in virtual files or may have not been written to the file system yet. Also added a basic test.π Checklist