Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vite): let rollup know that public assets are handled as externals #26551

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(vite): let rollup know that public assets are handled as externals #26551

wants to merge 2 commits into from
+29 −3

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #26379

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This suppresses the warning vite was throwing when using public assets in CSS, by letting rollup know that these assets can be resolved as externals.

We could also consider simply suppressing logs about these particular assets, if you're worried about any negative performance costs.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from antfu March 29, 2024 14:08
@danielroe danielroe self-assigned this Mar 29, 2024
@stackblitz StackBlitz
Copy link

stackblitz bot commented Mar 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pi0
Copy link
Member

pi0 commented Mar 29, 2024

Seems something we might expose and reuse from nitro in future for scanning public assets

@danielroe danielroe marked this pull request as draft March 29, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu Awaiting requested review from antfu

At least 1 approving review is required to merge this pull request.

Assignees

@danielroe danielroe

Labels
3.x bug dx 🍰 p2-nice-to-have vite
Projects
None yet
Milestone
No milestone
2 participants
@danielroe @pi0