Restart server on failure when running Windows app #3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorganca
commented
Apr 28, 2024
| @@ -143,15 +147,12 @@ func SpawnServer(ctx context.Context, command string) (chan int, error) { | |||
| default: | |||
| crashCount++ | |||
| slog.Warn(fmt.Sprintf("server crash %d - exit code %d - respawning", crashCount, code)) | |||
| time.Sleep(500 * time.Millisecond) | |||
| if err := cmd.Start(); err != nil { | |||
There was a problem hiding this comment.
Start() can only be called once for each exec.Cmd instance and so we need to create a new one on every restart
jmorganca
commented
Apr 28, 2024
| } | ||
| } | ||
|
|
||
| func start(ctx context.Context, command string) (*exec.Cmd, error) { |
There was a problem hiding this comment.
start factors out the setup of the exec.Cmd
dhiltgen
approved these changes
Apr 28, 2024
| slog.Info("starting server...") | ||
| cmd, err := start(ctx, command) | ||
| if err != nil { | ||
| slog.Error(fmt.Sprintf("failed to start server %s", err)) |
There was a problem hiding this comment.
I think this should continue the for loop so we don't crash on a nil pointer with cmd.Wait() below.
There was a problem hiding this comment.
Ah great catch. Thank you!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.