New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #20166 : Updates character ‘s’ Next to Edit Icon in ‘Insert Image’ of RTE with 'SVG' #20209
Conversation
Assigning @kevintab95 for the first pass review of this PR. Thanks! |
@Akhilesh-max Thanks for the fix. The pencil should take priority and the "SVG" is just an annotation to it. Can you make the "SVG" text smaller, or the pencil icon bigger, or put the "SVG" text under the pencil icon or somewhere else so that it looks cleaner/clearer? Thanks. |
@seanlip Looks good? Updated the image in the PR. |
@Akhilesh-max Better, but still one question. Why is the "SVG" font a serif font? It looks out of place with the rest of the text on the screen. |
@seanlip, the different font was being inherited from the i tag. I had two options to address this: either change the font family of the SVG text to match with the rest of the page or move it outside the i tag and adjust the alignment accordingly. I decided to go with the first option and changed the font family of the SVG text. However, please let me if it's ok this way. (Have updated the image in the description) Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Assigning @kevintab95 for codeowners. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Akhilesh-max!
Hi @Akhilesh-max, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
…Image’ of RTE with 'SVG' (oppia#20209) * updates * updates * updates
Overview
Essential Checklist
Please follow the instructions for making a code change.
Proof that changes are correct
Before :
After :
PR Pointers