Comment on Files in a Pull Request (Beta) Feedback #49954
Replies: 98 comments 48 replies
-
Thank you for adding this feature, I typically leave general comments linked to the bottom line of a file; it'll be much nicer to leave a more general comment. 🙏🏻 |
Beta Was this translation helpful? Give feedback.
-
Love this! This is going to be super useful 🥳 |
Beta Was this translation helpful? Give feedback.
-
Love this direction! Feedback: It seems that leaving a file-level review comment on a deleted file right now shows that comment as Outdated and isn't displayed in the file view, only being visible in the conversation timeline. |
Beta Was this translation helpful? Give feedback.
-
I've always wanted this! thank you for adding it! |
Beta Was this translation helpful? Give feedback.
-
Awesome, thank you very much Now the only remaining things are being able to comment on an unchanged line, and the commit message 🥳 |
Beta Was this translation helpful? Give feedback.
-
Cool, I love this. Feedback 1: When you mark a file as viewed or collapse it, the comment is still visible, which makes it take up a lot of vertical space. I mark them as viewed / collapsed when I'm done thinking about the file, and don't want it taking up space and attention, so I'd rather the comment is not visible then. Perhaps showing in the bar with the filename how many comments are in the file would make it still known when there's a comment on a collapsed file without taking up attention. And you could also have it count comments within the file, which would make it easier to see which files there's discussion on when you have 20 collapsed files in a review, without having to open every one. Feedback 2: Sometimes I put comments on arbitrary lines when I want to have a threaded discussion instead of it being part of the main PR comment thread. If you could reply to/resolve PR comments that aren't attached to a line/file, or if you could make feedback comments that aren't attached to a line or file, that could remove another reason for putting comments on lines that they don't belong to. (In my mental model, there's a distinction between discussions for specific pieces of feedback, which should be threadable/resolvable and might or might not belong to a line or file, and overall comments which belong in the main thread.) |
Beta Was this translation helpful? Give feedback.
-
This is super useful, previously I needed to add generic comments mentioning files, now this will point to the exact file 👍 |
Beta Was this translation helpful? Give feedback.
-
This is a great step in the right direction. Next step is to allow commenting on a specific line on any of the files changed in a PR. |
Beta Was this translation helpful? Give feedback.
-
This is great! In addition to:
it also enables adding a comment on an empty file that was accidentally committed, which coincidentally I had to work around just a few hours ago, but now I can comment directly on it 🤩 Thanks! |
Beta Was this translation helpful? Give feedback.
-
This is great and something I've long wanted. I would also like the ability to comment on lines in a file that were NOT changed. |
Beta Was this translation helpful? Give feedback.
-
Great! 🚀 |
Beta Was this translation helpful? Give feedback.
-
A nice feature, I was adding comments for the first line of the file before 😭 |
Beta Was this translation helpful? Give feedback.
-
Today I ran into an issue. If I try to comment on a file while viewing a single commit in a PR, the comment area tries to open, but nothing is displayed. While, on the other hand, if I review all the changes at once, it works as expected. Short video demo: Screen.Recording.2023-05-05.at.9.56.16.AM_compressed.mp4 |
Beta Was this translation helpful? Give feedback.
-
I've noticed that pending whole-file comments on PRs are not collapsed/hidden when checking the "Viewed" checkbox. It's not clear if this is intended behavior - per-line comments are collapsed/hidden when marking a file as viewed. |
Beta Was this translation helpful? Give feedback.
-
Love this feature! |
Beta Was this translation helpful? Give feedback.
-
Thanks for the patch, working as expected. |
Beta Was this translation helpful? Give feedback.
-
Awesome, thanks @willsmythe and team! |
Beta Was this translation helpful? Give feedback.
-
Very useful, long overdue. Thanks! |
Beta Was this translation helpful? Give feedback.
-
This is great! |
Beta Was this translation helpful? Give feedback.
-
Awesome work @willsmythe and team! 🙌 have been waiting for decades for this... hahaha |
Beta Was this translation helpful? Give feedback.
-
Finally the GitHub gods deem it useful and worth their effort. |
Beta Was this translation helpful? Give feedback.
-
Perfect! Great work! |
Beta Was this translation helpful? Give feedback.
-
This is really helpful, Thanks 🎉 |
Beta Was this translation helpful? Give feedback.
-
I was looking forward to this feature, CONGRATULATIONS and THANK YOU guys !!! |
Beta Was this translation helpful? Give feedback.
-
This will be very useful , congratulations for you guys. |
Beta Was this translation helpful? Give feedback.
-
THANK YOU! I missed this from BitBucket. SO VERY USEFUL; sometimes when I want to talk about the whole file. No need to click the first line anymore. |
Beta Was this translation helpful? Give feedback.
-
Always wanted this. It lacked a way to put general comments for a whole file 🙏🏽 Thanks |
Beta Was this translation helpful? Give feedback.
-
Looks great! I hope at some point this functionality also makes its way to the Github Pull Request Extension. |
Beta Was this translation helpful? Give feedback.
-
Commenting on a file in a pull request (not just a specific line) is
available in public betanow generally available.This feature lets you comment on deleted, binary (including images), and renamed files in a pull request. You can also comment generally about a changed code file without having to attach the comment to a specific line.
Learn more about commenting on a pull request (docss) or see the beta changelog for more details.
Known issues
GitHub Mobile support is coming🎉 SHIPPED 🎉API support is coming🎉 SHIPPED 🎉Tell us what you think
Let us know if you run into problems, have questions, have a request, or just wanna say how useful (or not) this feature is!
Beta Was this translation helpful? Give feedback.
All reactions