Handle escaped '%' in commands data section #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
commented
Nov 18, 2019
src/Runner.Common/ActionCommand.cs
Outdated
| @@ -18,6 +18,7 @@ public sealed class ActionCommand | |||
|
|
|||
| private static readonly EscapeMapping[] _escapeDataMappings = new[] | |||
| { | |||
| new EscapeMapping(token: "%", replacement: "%25"), | |||
There was a problem hiding this comment.
@TingluoHuang any reason not to handle this? This enables literal %0A or %0D
TingluoHuang
approved these changes
Nov 18, 2019
|
Whats the motivation here? Can we link to an issue? We should also update the toolkit |
5d056a7
to
36d110f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #267