Calculate docker instance label based on the hash of the config #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerl
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
LGTM
This will make the docker instance label unique even if the runners sharing the same docker socket through docker-from-docker are under the same path in their respective containers.
Hashing the entire .runner file means that changes to this file (e.g. runnergroupname) will be reflected as a change in docker instance label as well - we found this acceptable as this change would happen outside of a running job, which means the docker network created based on this label in a previous job has been disposed.
This was referenced Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2647
The issue can occur when multiple runners are sharing the same docker socket, and they are executing within a container.
The well known directory is going to be the same for both runners, assuming they are executing the same image.
So when docker instance is calculated, the paths within the container are going to be exactly the same, one runner can remove resources owned by the other runner.
The fix uses the
.runnerfile, which is unique per runner to calculate instance label, which should eliminate collision issues.