Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query runner by name on server side. #2771

Merged
merged 1 commit into from Aug 25, 2023
Merged

Query runner by name on server side. #2771

merged 1 commit into from Aug 25, 2023

Conversation

TingluoHuang
Copy link
Member

Once the runner-admin service support query runner by name, we can move the query to use server side filter instead of fetching all the runners from the server and do the filter on the client side.

@TingluoHuang TingluoHuang requested a review from a team as a code owner August 16, 2023 03:55
vanZeben
vanZeben approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@vanZeben vanZeben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TingluoHuang TingluoHuang merged commit e0acb14 into main Aug 25, 2023
10 checks passed
@TingluoHuang TingluoHuang deleted the users/tihuang/getrunnerbyname branch August 25, 2023 01:02
@TingluoHuang TingluoHuang mentioned this pull request Aug 25, 2023
Merged
@github-actions github-actions bot mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanZeben vanZeben vanZeben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TingluoHuang @vanZeben