Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default version to node20 #2844

Merged
merged 1 commit into from Oct 9, 2023
Merged

Update default version to node20 #2844

merged 1 commit into from Oct 9, 2023

Conversation

takost
Copy link
Contributor

@takost takost commented Sep 11, 2023 •
edited

Make node20 default node version for runner internal operations. This can be opted-out by starting Runner with ACTIONS_RUNNER_FORCED_INTERNAL_NODE_VERSION=node16 or if DistributedTask.ForceInternalNodeVersionOnRunnerTo16 FF set to true (PR: https://github.com/github/actions-dotnet/pull/16155).

@takost takost requested a review from a team as a code owner September 11, 2023 13:13
@TingluoHuang TingluoHuang enabled auto-merge (squash) October 9, 2023 04:11
@TingluoHuang TingluoHuang merged commit acdc6ed into main Oct 9, 2023
10 checks passed
@TingluoHuang TingluoHuang deleted the takost/update-internal-node branch October 9, 2023 04:48
@ajschmidt8
Copy link
Contributor

cross-posting the issue I created below for visibility:

The transition from Node 16 to Node 20 conflicts with the actions/runner claim of support for CentOS 7.

@jeremy-ke
Copy link

just in case anyone else runs into this issue running github agents on amazonlinux2 - github agent service startup mentioned a missing GLIBC_2.27/GLIBC_2.28 dependency for node20.

as mentioned in the pr description, setting export GITHUB_ACTIONS_RUNNER_FORCED_NODE_VERSION=node16 in the user data resolved this

@jonanderson10
Copy link

just in case anyone else runs into this issue running github agents on amazonlinux2 - github agent service startup mentioned a missing GLIBC_2.27/GLIBC_2.28 dependency for node20.

as mentioned in the pr description, setting export GITHUB_ACTIONS_RUNNER_FORCED_NODE_VERSION=node16 in the user data resolved this

I just ran into this as well, thanks!

@tristanhill-iris tristanhill-iris mentioned this pull request Oct 9, 2023
Closed
@github-actions github-actions bot mentioned this pull request Oct 10, 2023
Merged
@charlesdg charlesdg mentioned this pull request Oct 10, 2023
Closed
@PatrickMilroy PatrickMilroy mentioned this pull request Oct 10, 2023
Open
takost added a commit that referenced this pull request Oct 10, 2023
@takost
Revert "Update default version to node20 (#2844)"
25af09f 
This reverts commit acdc6ed.
takost added a commit that referenced this pull request Oct 10, 2023
@takost
Revert "Update default version to node20 (#2844)" (#2918)
544f190 
This reverts commit acdc6ed.
takost added a commit that referenced this pull request Oct 10, 2023
@takost
Revert "Update default version to node20 (#2844)" (#2918)
3424e3a 
This reverts commit acdc6ed.
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Merged
@damyan damyan mentioned this pull request Oct 24, 2023
Open
@alec-drw alec-drw mentioned this pull request Oct 26, 2023
Closed
2 tasks
@austinvalle austinvalle mentioned this pull request Oct 31, 2023
Closed
takost added a commit that referenced this pull request Apr 18, 2024
@takost
Revert "Revert "Update default version to node20 (#2844)" (#2918)"
7f9c42f 
This reverts commit 544f190.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanZeben vanZeben vanZeben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@takost @ajschmidt8 @jeremy-ke @jonanderson10 @vanZeben @TingluoHuang