Throw NonRetryableException on GetNextMessage from broker as needed. #2828

TingluoHuang · 2023-09-05T20:59:42Z

The runner exit itself as expected instead of a infinite restart loop.

@TingluoHuang ➜ /workspaces/actions/runner/_layout $ ./run.sh 
Current runner version: '2.308.0'
2023-09-05 18:10:10Z: Listening for Jobs
2023-09-05 18:10:56Z: Runner connect error: Failed to get job message: Error: Not Found. Retrying until reconnected.
An error occurred: Get next message failed with non-retryable error.
Runner listener exit with terminated error, stop the service, no retry needed.
Exiting runner...

TingluoHuang · 2023-09-05T21:01:34Z

src/Runner.Listener/BrokerMessageListener.cs

@@ -108,7 +108,7 @@ public async Task<TaskAgentMessage> GetNextMessageAsync(CancellationToken token)

                    if (!IsGetNextMessageExceptionRetriable(ex))
                    {
-                        throw;
+                        throw new NonRetryableException("Get next message failed with non-retryable error.", ex);


We didn't do this with the other Listener since we are preventing the loop during CreateSeesion.

Since the broker listener doesn't really have a concept for create session, i need to break out the loop at here for now.

…ctions#2828)

Throw NonRetryableException on GetNextMessage from broker as needed.

34df752

TingluoHuang requested a review from a team as a code owner September 5, 2023 20:59

TingluoHuang commented Sep 5, 2023

View reviewed changes

luketomlinson approved these changes Sep 5, 2023

View reviewed changes

TingluoHuang merged commit d2f0a46 into main Sep 5, 2023
10 checks passed

TingluoHuang deleted the users/tihuang/runnerdel branch September 5, 2023 21:21

ashb pushed a commit to ashb/runner that referenced this pull request Sep 6, 2023

Throw NonRetryableException on GetNextMessage from broker as needed. (a…

9a5a13a

…ctions#2828)

github-actions bot mentioned this pull request Sep 8, 2023

Update GH Runner from 2.308.0 to 2.309.0 PasseiDireto/gh-runner#85

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Throw NonRetryableException on GetNextMessage from broker as needed. #2828

Throw NonRetryableException on GetNextMessage from broker as needed. #2828

TingluoHuang commented Sep 5, 2023 •

edited

TingluoHuang Sep 5, 2023

Throw NonRetryableException on GetNextMessage from broker as needed. #2828

Throw NonRetryableException on GetNextMessage from broker as needed. #2828

Conversation

TingluoHuang commented Sep 5, 2023 • edited

TingluoHuang Sep 5, 2023

Choose a reason for hiding this comment

TingluoHuang commented Sep 5, 2023 •

edited