Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user-agent to all http clients using RawClientHttpRequestSettings. #3115

Merged
merged 1 commit into from Jan 30, 2024
Merged

Add user-agent to all http clients using RawClientHttpRequestSettings. #3115

merged 1 commit into from Jan 30, 2024

Conversation

TingluoHuang
Copy link
Member

Before:

User-Agent: VSServices/2.312.0.0
(NetStandard; Darwin 23.3.0 Darwin Kernel Version 23.3.0: Wed Dec 20 21:30:44 PST 2023; root:xnu-10002.81.5~7/RELEASE_ARM64_T6000)

After:

User-Agent: VSServices/2.312.0.0 (NetStandard; Darwin 23.3.0 Darwin Kernel Version 23.3.0: Wed Dec 20 21:30:44 PST 2023; root:xnu-10002.81.5~7/RELEASE_ARM64_T6000) 
GitHubActionsRunner-osx-arm64/2.312.0
HttpProxyConfigured/True
ClientId/1ef6c146-8b46-40ab-b57f-0871bfc614b5 
RunnerId/2 
GroupId/1 
CommitSHA/2e8e48f2a53cf8077b7d27d7064943622ad42786 
OrchestrationId/aee4139d-34c5-429f-8ab3-07c2b6058396.build_and_test.relwithdebinfo.main.main.__default
(Darwin 23.3.0 Darwin Kernel Version 23.3.0: Wed Dec 20 21:30:44 PST 2023; root:xnu-10002.81.5~7/RELEASE_ARM64_T6000)

So we can have better correlation better telemetry and the runner.

Fixing: https://github.com/github/actions-results-team/issues/2204

@TingluoHuang TingluoHuang requested a review from a team as a code owner January 30, 2024 04:59
@TingluoHuang TingluoHuang merged commit 7414e08 into main Jan 30, 2024
10 checks passed
@TingluoHuang TingluoHuang deleted the users/tihuang/resultsua branch January 30, 2024 18:39
@github-actions github-actions bot mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luketomlinson luketomlinson luketomlinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TingluoHuang @luketomlinson