Fix #19311:[Bug fixing]Edge arrows do not scale on zoom in/out #19384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Ovilia
requested changes
Dec 14, 2023
There was a problem hiding this comment.
Thanks for your contribution.
I don't think the original behavior is a bug because the size of the symbol is in pixels and thus it's natural to remain unchanged when zooming. However, I think this could serve as a new feature with an extra option called symbolScaleRatio, and works lile nodeScaleRatio.
|
Please also fix the lint problems. |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19384@63f6ea3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Edge arrows now scale upon zooming in and out in graph view, just like the nodes
Fixed issues
#19311
Details
Before: What was the problem?
When zooming in and out on a graph, the nodes scale properly, but the arrows on the edges do not. This results in a visual imbalance where the arrows appear disproportionately large or small compared to the nodes at different zoom levels, leading to a degradation in the readability and aesthetic appeal of the graph.
Before Zooming:
After Zooming:
After: How does it behave after the fixing?
The arrows on the edges now scale in proportion with the nodes, maintaining a consistent and relative size at all zoom levels, ensuring a balanced and visually coherent graph representation, irrespective of the zoom.
Here the node is size 20 and arrow is 10. As shown in the screenshots, on both zoom levels, the arrow appears to be about half as large as the node.
Before Zooming:
After Zooming:
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information