Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add script #12673

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

add script #12673

wants to merge 14 commits into from

Conversation

heliuchuan
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Mar 25, 2024 •
edited

⏱️ 11h 26m total CI duration on this PR
Job Cumulative Duration Recent Runs
windows-build 3h 25m 🟩 🟩 🟩 🟩 🟩 (+7 more)
rust-unit-tests 2h 59m 🟩 ⬜ 🟩 🟩 🟩 (+8 more)
rust-lints 1h 13m 🟩 ⬜ 🟩 🟩 🟩 (+8 more)
rust-move-tests 1h 5m 🟩 🟩 🟩 🟩 🟩 (+8 more)
run-tests-main-branch 55m 🟩 🟩 🟩 🟩 🟩 (+8 more)
check 43m 🟩 🟩 ⬜ 🟩 🟩 (+7 more)
check-dynamic-deps 26m 🟩 ⬜ 🟩 🟩 🟩 (+8 more)
general-lints 24m 🟩 ⬜ 🟩 🟩 🟩 (+8 more)
semgrep/ci 6m 🟩 🟩 🟩 🟩 🟩 (+8 more)
file_change_determinator 3m 🟩 🟩 🟩 🟩 🟩 (+8 more)
file_change_determinator 3m 🟩 🟩 🟩 🟩 🟩 (+8 more)
file_change_determinator 1m 🟩 🟩 🟩 🟩 🟩 
permission-check 41s 🟩 🟩 🟩 🟩 🟩 (+6 more)
permission-check 33s 🟩 🟩 🟩 🟩 🟩 (+6 more)
permission-check 33s 🟩 🟩 🟩 🟩 🟥 (+6 more)
permission-check 27s 🟩 🟩 🟩 🟩 🟩 (+6 more)

🚨 3 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-lints 6m 7m -24%
windows-build 12m 20m -39%
rust-move-tests 3s 8m -99%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekflyer geekflyer geekflyer approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heliuchuan @geekflyer