Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deposit in prologue and refund in epilogue to prevent undergasing attack for randomness txns #12695
deposit in prologue and refund in epilogue to prevent undergasing attack for randomness txns #12695
Changes from all commits
ef5426e
0216cff
037b603
6542853
0fe1b60
a49e1ab
f7ed14f
376581e
eca457d
3031579
c419ac8
100b044
2fb941f
cb0f66c
64abcc9
7145a69
79b88d6
69838d4
d090f6a
dbb03eb
cf9ebc5
c62b5c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be
has_randomness_attribute(resolver, session, entry_func)?
and the return type ofget_required_deposit
should be a result of an option. Here you are remapping storage error to non-existent attribute which is wrongThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then we have some new test failures... some txn supposed to be accepted is now rejected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to me it means we do have to tolerate those
get_required_deposit
errors?