Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for ASCII copyrights by using multiple license files in pre-commit script #12693

Merged
merged 2 commits into from Apr 12, 2024
Merged

Prepare for ASCII copyrights by using multiple license files in pre-commit script #12693

merged 2 commits into from Apr 12, 2024

Conversation

brmataptos
Copy link
Contributor

@brmataptos brmataptos commented Mar 26, 2024 •
edited

Description

Add multiple allowed license files to pre-commit script, tolerating
existing UTF8-encoded (c) symbols but adding ASCII-only notices if
missing. Update 3 .rs files that were missing Copyright notices.

Add a section for third_party license notices.

This enables #12687, which will have a race with other code changes.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Local testing.

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Mar 26, 2024 •
edited

⏱️ 6h 36m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 1h 38m 🟩 🟥 ⬜ 🟥 🟩 
rust-move-unit-coverage 1h 27m 🟩 🟩 🟩 🟩 🟩 
windows-build 1h 11m 🟩 🟩 🟩 🟩 🟩 
rust-move-tests 1h 8m 🟩 🟩 🟩 🟩 🟩 
run-tests-main-branch 21m 🟩 🟩 🟩 🟩 🟩 
rust-lints 19m 🟥 🟥 🟥 🟥 🟩 
check-dynamic-deps 11m 🟩 🟩 🟩 🟩 🟩 
general-lints 10m 🟩 🟩 🟩 🟩 🟩 
check 6m 🟥 🟥 🟥 🟥 🟥 
semgrep/ci 2m 🟩 🟩 🟩 🟩 🟩 
file_change_determinator 54s 🟩 🟩 🟩 🟩 🟩 
file_change_determinator 45s 🟩 🟩 🟩 🟩 🟩 
permission-check 14s 🟩 🟩 🟩 🟩 🟩 
permission-check 14s 🟩 🟩 🟩 🟩 🟩 
permission-check 12s 🟩 🟩 🟩 🟩 🟩 
permission-check 11s 🟩 🟩 🟩 🟩 🟩 

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-move-tests 13m 17m -23%
windows-build 12m 20m -40%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@codecov Codecov
Copy link

codecov bot commented Mar 26, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.6%. Comparing base (7647a94) to head (97cc3fd).

❗ Current head 97cc3fd differs from pull request most recent head aed6590. Consider uploading reports for the commit aed6590 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##             main   #12693     +/-   ##
=========================================
- Coverage    62.6%    62.6%   -0.1%     
=========================================
  Files         823      822      -1     
  Lines      184343   184199    -144     
=========================================
- Hits       115499   115390    -109     
+ Misses      68844    68809     -35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brmataptos
Copy link
Contributor Author

rebased, and tweaked a little.

@brmataptos brmataptos enabled auto-merge (squash) April 11, 2024 22:55
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.10.1 ==> aed6590e5f1e9e3c6be024b4a1a550144d9c4c64

Compatibility test results for aptos-node-v1.10.1 ==> aed6590e5f1e9e3c6be024b4a1a550144d9c4c64 (PR)
1. Check liveness of validators at old version: aptos-node-v1.10.1
compatibility::simple-validator-upgrade::liveness-check : committed: 6981 txn/s, latency: 4751 ms, (p50: 4800 ms, p90: 7500 ms, p99: 8000 ms), latency samples: 244360
2. Upgrading first Validator to new version: aed6590e5f1e9e3c6be024b4a1a550144d9c4c64
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1760 txn/s, latency: 16473 ms, (p50: 18000 ms, p90: 24300 ms, p99: 24600 ms), latency samples: 89760
3. Upgrading rest of first batch to new version: aed6590e5f1e9e3c6be024b4a1a550144d9c4c64
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1775 txn/s, latency: 16306 ms, (p50: 19300 ms, p90: 22400 ms, p99: 22800 ms), latency samples: 92320
4. upgrading second batch to new version: aed6590e5f1e9e3c6be024b4a1a550144d9c4c64
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 3499 txn/s, latency: 9186 ms, (p50: 9600 ms, p90: 12600 ms, p99: 12900 ms), latency samples: 146980
5. check swarm health
Compatibility test for aptos-node-v1.10.1 ==> aed6590e5f1e9e3c6be024b4a1a550144d9c4c64 passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on aed6590e5f1e9e3c6be024b4a1a550144d9c4c64

two traffics test: inner traffic : committed: 7634 txn/s, latency: 5133 ms, (p50: 5100 ms, p90: 6000 ms, p99: 10200 ms), latency samples: 3305740
two traffics test : committed: 100 txn/s, latency: 1868 ms, (p50: 1900 ms, p90: 2100 ms, p99: 2300 ms), latency samples: 1780
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.206, avg: 0.202", "QsPosToProposal: max: 0.297, avg: 0.265", "ConsensusProposalToOrdered: max: 0.481, avg: 0.440", "ConsensusOrderedToCommit: max: 0.333, avg: 0.313", "ConsensusProposalToCommit: max: 0.765, avg: 0.753"]
Max round gap was 1 [limit 4] at version 1491757. Max no progress secs was 4.969719 [limit 15] at version 1491757.
Test Ok

@brmataptos brmataptos merged commit 1d72a76 into main Apr 12, 2024
52 of 53 checks passed
@brmataptos brmataptos deleted the brm-issue-12671-pre-commit branch April 12, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmouse msmouse msmouse approved these changes

@JoshLind JoshLind JoshLind approved these changes

@wrwg wrwg Awaiting requested review from wrwg

@vineethk vineethk Awaiting requested review from vineethk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brmataptos @msmouse @JoshLind