Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[replay-verify] cherrypick add new range to release 1.10 #12708

Merged
merged 3 commits into from Mar 28, 2024
Merged

[replay-verify] cherrypick add new range to release 1.10 #12708

merged 3 commits into from Mar 28, 2024

Conversation

areshand
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Mar 27, 2024 •
edited

⏱️ 80h 9m total CI duration on this PR
Job Cumulative Duration Recent Runs
test-replay / replay-verify (16) 6h 1m 🟥 🟥 🟥 
test-replay / replay-verify (9) 6h 1m 🟥 🟥 🟥 
test-replay / replay-verify (10) 6h 1m 🟥 🟥 🟥 
test-replay / replay-verify (8) 5h 53m 🟥 🟥 🟩 
test-replay / replay-verify (11) 4h 58m 🟩 🟩 🟩 
test-replay / replay-verify (15) 4h 51m 🟩 🟩 🟩 
test-replay / replay-verify (0) 4h 9m 🟩 🟩 🟩 
test-replay / replay-verify (6) 4h 7m 🟩 🟩 🟩 
test-replay / replay-verify (12) 3h 46m 🟩 🟩 🟩 
test-replay / replay-verify (2) 3h 35m 🟩 🟩 🟩 
test-replay / replay-verify (13) 3h 18m 🟩 🟩 🟩 
test-replay / replay-verify (1) 3h 12m 🟩 🟩 🟩 
test-replay / replay-verify (4) 3h 3m 🟩 🟩 🟩 
test-replay / replay-verify (14) 2h 59m 🟩 🟩 🟩 
test-replay / replay-verify (5) 2h 50m 🟩 🟩 🟩 
test-replay / replay-verify (7) 2h 33m 🟩 🟩 🟩 
test-replay / replay-verify (3) 2h 31m 🟩 🟩 🟩 
rust-unit-tests 2h 26m ⬜ 🟩 🟩 🟩 
windows-build 1h 52m 🟩 🟩 🟩 🟩 
rust-smoke-tests 1h 40m 🟩 🟩 🟩 
execution-performance / single-node-performance 1h 3m 🟩 🟩 🟩 
rust-lints 35m 🟩 🟩 🟩 🟩 
rust-images / rust-all 28m 🟩 🟥 🟥 🟩 
forge-compat-test / forge 27m 🟩 🟩 
run-tests-main-branch 26m 🟥 🟥 🟥 🟥 
cli-e2e-tests / run-cli-tests 21m 🟩 🟥 🟩 
forge-e2e-test / forge 20m 🟥 🟥 🟩 
check 17m 🟩 🟩 🟩 🟩 
general-lints 10m 🟩 🟩 🟩 🟩 
check-dynamic-deps 8m 🟩 🟩 🟩 🟩 
node-api-compatibility-tests / node-api-compatibility-tests 2m 🟩 🟩 
semgrep/ci 2m 🟩 🟩 🟩 🟩 
file_change_determinator 55s 🟩 🟩 🟩 🟩 
file_change_determinator 43s 🟩 🟩 🟩 🟩 
execution-performance / file_change_determinator 33s 🟩 🟩 🟩 
file_change_determinator 31s 🟩 🟩 🟩 
determine-test-metadata 22s 🟩 🟩 🟩 
permission-check 18s 🟩 🟩 🟩 🟩 
permission-check 14s 🟩 🟩 🟩 
permission-check 14s 🟩 🟩 🟩 🟩 
permission-check 14s 🟩 🟩 🟩 🟩 
permission-check 13s 🟩 🟩 🟥 🟩 
determine-docker-build-metadata 9s 🟩 🟩 🟩 

🚨 4 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
run-tests-main-branch 6m 4m +56%
rust-unit-tests 36m 26m +36%
windows-build 27m 20m +34%
rust-lints 9m 7m +22%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@areshand areshand marked this pull request as ready for review March 27, 2024 16:30
@areshand areshand requested review from a team as code owners March 27, 2024 16:30
@areshand areshand changed the title [replay-verify] add new range [replay-verify] cherrypick add new range to release 1.10 Mar 27, 2024
@areshand areshand enabled auto-merge (rebase) March 27, 2024 17:06
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.9.5 ==> 6bf2b9c2aa02118ed08994685192ffc900749565

Compatibility test results for aptos-node-v1.9.5 ==> 6bf2b9c2aa02118ed08994685192ffc900749565 (PR)
1. Check liveness of validators at old version: aptos-node-v1.9.5
compatibility::simple-validator-upgrade::liveness-check : committed: 6905 txn/s, latency: 4813 ms, (p50: 4800 ms, p90: 7800 ms, p99: 8400 ms), latency samples: 241680
2. Upgrading first Validator to new version: 6bf2b9c2aa02118ed08994685192ffc900749565
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 806 txn/s, latency: 33463 ms, (p50: 37700 ms, p90: 50900 ms, p99: 51800 ms), latency samples: 58060
3. Upgrading rest of first batch to new version: 6bf2b9c2aa02118ed08994685192ffc900749565
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 42 txn/s, submitted: 606 txn/s, expired: 564 txn/s, latency: 17617 ms, (p50: 15800 ms, p90: 16900 ms, p99: 54300 ms), latency samples: 2797
4. upgrading second batch to new version: 6bf2b9c2aa02118ed08994685192ffc900749565
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 2222 txn/s, latency: 12610 ms, (p50: 13500 ms, p90: 14800 ms, p99: 19900 ms), latency samples: 108920
5. check swarm health
Compatibility test for aptos-node-v1.9.5 ==> 6bf2b9c2aa02118ed08994685192ffc900749565 passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 6bf2b9c2aa02118ed08994685192ffc900749565

two traffics test: inner traffic : committed: 6249 txn/s, latency: 6214 ms, (p50: 5700 ms, p90: 8100 ms, p99: 14800 ms), latency samples: 2743480
two traffics test : committed: 100 txn/s, latency: 2064 ms, (p50: 2000 ms, p90: 2400 ms, p99: 6600 ms), latency samples: 1900
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.219, avg: 0.201", "QsPosToProposal: max: 0.275, avg: 0.206", "ConsensusProposalToOrdered: max: 0.585, avg: 0.546", "ConsensusOrderedToCommit: max: 0.454, avg: 0.414", "ConsensusProposalToCommit: max: 1.005, avg: 0.960"]
Max round gap was 2 [limit 4] at version 2757974. Max no progress secs was 8.362764 [limit 15] at version 2757974.
Test Ok

@areshand areshand merged commit 79fa47c into aptos-release-v1.10 Mar 28, 2024
66 of 71 checks passed
@areshand areshand deleted the cherry_pick_replay_verify_change branch March 28, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidiw davidiw davidiw approved these changes

@msmouse msmouse msmouse approved these changes

@igor-aptos igor-aptos igor-aptos approved these changes

@grao1991 grao1991 Awaiting requested review from grao1991

@danielxiangzl danielxiangzl Awaiting requested review from danielxiangzl

@sausagee sausagee Awaiting requested review from sausagee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@areshand @davidiw @msmouse @igor-aptos