Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable allow_batches_without_pos_in_proposal flag #12710

Merged
merged 9 commits into from Apr 3, 2024
Merged

Enable allow_batches_without_pos_in_proposal flag #12710

merged 9 commits into from Apr 3, 2024

Conversation

vusirikala
Copy link
Contributor

@vusirikala vusirikala commented Mar 27, 2024 •
edited

Description

Enable allow_batches_without_pos_in_proposal flag to enable the inline batches in payload.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Mar 27, 2024 •
edited

⏱️ 36h 49m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-coverage 9h 5m 🟩 🟩 
rust-smoke-coverage 7h 42m 🟩 🟩 
windows-build 3h 42m 🟩 🟩 🟩 🟩 🟩 (+6 more)
execution-performance / single-node-performance 3h 33m 🟩 🟩 🟩 🟩 🟩 (+5 more)
rust-smoke-tests 2h 12m ⬜ ⬜ ⬜ 🟩 🟩 (+3 more)
rust-unit-tests 2h 8m ⬜ ⬜ ⬜ 🟩 🟩 (+4 more)
rust-images / rust-all 1h 9m ⬜ ⬜ 🟩 ⬜ 🟩 (+5 more)
forge-compat-test / forge 1h 5m 🟥 🟥 🟥 🟥 🟩 
forge-e2e-test / forge 57m 🟩 🟩 🟩 🟩 
adhoc-forge-test / forge 56m 🟩 
run-tests-main-branch 45m 🟩 🟩 🟩 🟩 🟩 (+6 more)
rust-lints 41m ⬜ ⬜ 🟥 🟩 🟩 (+4 more)
cli-e2e-tests / run-cli-tests 34m 🟩 🟥 🟩 🟩 
check 30m ⬜ ⬜ 🟥 🟩 🟩 (+6 more)
rust-move-tests 28m 🟩 🟩 🟩 🟩 🟩 (+5 more)
check-dynamic-deps 25m 🟩 🟩 🟩 🟩 🟩 (+6 more)
general-lints 18m ⬜ ⬜ 🟩 🟩 🟩 (+4 more)
rust-build-cached-packages 11m 🟩 🟩 🟩 
semgrep/ci 4m 🟩 🟩 🟩 🟩 🟩 (+6 more)
node-api-compatibility-tests / node-api-compatibility-tests 3m 🟩 🟩 🟩 🟩 
file_change_determinator 3m 🟩 🟩 🟩 🟩 🟩 (+7 more)
execution-performance / file_change_determinator 3m 🟩 🟩 🟩 🟩 🟩 (+5 more)
file_change_determinator 3m 🟩 🟩 🟩 🟩 🟩 (+6 more)
indexer-grpc-e2e-tests / test-indexer-grpc-docker-compose 3m 🟩 
file_change_determinator 2m 🟩 🟩 🟩 🟩 🟩 (+5 more)
file_change_determinator 2m 🟩 🟩 🟩 🟩 🟩 (+3 more)
permission-check 47s 🟩 🟩 🟩 🟩 🟩 (+7 more)
permission-check 44s 🟩 🟩 🟩 🟩 🟩 (+7 more)
permission-check 42s 🟩 🟩 🟩 🟩 🟩 (+5 more)
permission-check 36s 🟩 🟩 🟩 🟩 🟩 (+5 more)
permission-check 33s 🟩 🟩 🟩 🟩 🟩 (+4 more)
determine-docker-build-metadata 30s 🟩 🟩 🟩 🟩 🟩 (+6 more)
upload-to-codecov 26s 🟩 🟩 
determine-forge-run-metadata 2s 🟩 

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@vusirikala vusirikala requested review from bchocho and sitalkedia and removed request for gregnazario and JoshLind March 27, 2024 17:48
@vusirikala vusirikala added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Mar 27, 2024
@vusirikala vusirikala enabled auto-merge (squash) March 27, 2024 18:07
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.8%. Comparing base (b448c40) to head (2f88d6e).
Report is 4 commits behind head on main.

❗ Current head 2f88d6e differs from pull request most recent head 1ee2c13. Consider uploading reports for the commit 1ee2c13 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##             main   #12710       +/-   ##
===========================================
+ Coverage    62.6%    69.8%     +7.2%     
===========================================
  Files         819     2293     +1474     
  Lines      183611   436088   +252477     
===========================================
+ Hits       115062   304715   +189653     
- Misses      68549   131373    +62824

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vusirikala vusirikala added CICD:build-images when this label is present github actions will start build+push rust images from the PR. and removed CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR labels Mar 29, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@vusirikala vusirikala requested review from a team as code owners April 3, 2024 17:21
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

✅ Forge suite compat success on adhoc-20240328 ==> 1ee2c134b8b0c86010b0bfa450d206d291ca71ab

Compatibility test results for adhoc-20240328 ==> 1ee2c134b8b0c86010b0bfa450d206d291ca71ab (PR)
1. Check liveness of validators at old version: adhoc-20240328
compatibility::simple-validator-upgrade::liveness-check : committed: 6154 txn/s, latency: 5132 ms, (p50: 5000 ms, p90: 9000 ms, p99: 10500 ms), latency samples: 240020
2. Upgrading first Validator to new version: 1ee2c134b8b0c86010b0bfa450d206d291ca71ab
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 1846 txn/s, latency: 15860 ms, (p50: 18400 ms, p90: 22300 ms, p99: 22600 ms), latency samples: 90480
3. Upgrading rest of first batch to new version: 1ee2c134b8b0c86010b0bfa450d206d291ca71ab
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 1656 txn/s, latency: 16984 ms, (p50: 19200 ms, p90: 22000 ms, p99: 22600 ms), latency samples: 86160
4. upgrading second batch to new version: 1ee2c134b8b0c86010b0bfa450d206d291ca71ab
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 1700 txn/s, latency: 18461 ms, (p50: 20500 ms, p90: 27100 ms, p99: 29300 ms), latency samples: 81640
5. check swarm health
Compatibility test for adhoc-20240328 ==> 1ee2c134b8b0c86010b0bfa450d206d291ca71ab passed
Test Ok

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

✅ Forge suite realistic_env_max_load success on 1ee2c134b8b0c86010b0bfa450d206d291ca71ab

two traffics test: inner traffic : committed: 8011 txn/s, latency: 4897 ms, (p50: 4700 ms, p90: 5700 ms, p99: 11400 ms), latency samples: 3461160
two traffics test : committed: 100 txn/s, latency: 1810 ms, (p50: 1700 ms, p90: 2000 ms, p99: 2300 ms), latency samples: 1860
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.208, avg: 0.202", "QsPosToProposal: max: 0.300, avg: 0.252", "ConsensusProposalToOrdered: max: 0.455, avg: 0.415", "ConsensusOrderedToCommit: max: 0.337, avg: 0.317", "ConsensusProposalToCommit: max: 0.748, avg: 0.732"]
Max round gap was 1 [limit 4] at version 1674283. Max no progress secs was 4.944603 [limit 15] at version 1674283.
Test Ok

@vusirikala vusirikala merged commit dee2961 into main Apr 3, 2024
51 checks passed
@vusirikala vusirikala deleted the satya/enable-latency-reduction-flag branch April 3, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibalajiarun ibalajiarun ibalajiarun approved these changes

@sitalkedia sitalkedia sitalkedia approved these changes

@bchocho bchocho Awaiting requested review from bchocho

@zekun000 zekun000 Awaiting requested review from zekun000

Assignees
No one assigned
Labels
CICD:build-images when this label is present github actions will start build+push rust images from the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vusirikala @ibalajiarun @sitalkedia