[experimental] LayeredMap which views a sequence of MapLayers #12722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 4h 15m total CI duration on this PR
🚨 3 jobs on the last run were significantly faster/slower than expected
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
e43b2d5
to
b941c9e
Compare
areshand
reviewed
Apr 4, 2024
| use std::sync::{Arc, Weak}; | ||
|
|
||
| #[derive(Debug)] | ||
| pub enum Ref<T> { |
There was a problem hiding this comment.
similar to the Ref here https://github.com/aptos-labs/aptos-core/blob/main/storage/scratchpad/src/sparse_merkle/node.rs#L139. reuse?
There was a problem hiding this comment.
maybe, when it's out of '/experimental'
| #[derive(Debug)] | ||
| struct LayerInner<K: Key, V: Value> { | ||
| root: NodeRef<K, V>, | ||
| children: Mutex<Vec<Arc<LayerInner<K, V>>>>, |
There was a problem hiding this comment.
what is children used for?
There was a problem hiding this comment.
same with SMT, there can be branches in the block tree.
|
|
||
| #[derive(Clone, Debug)] | ||
| pub struct LayeredMap<K: Key, V: Value> { | ||
| bottom_layer: MapLayer<K, V>, |
There was a problem hiding this comment.
why do we need the bottom_layer? could we assume the LRU cache contains all the base key, value pairs?
There was a problem hiding this comment.
Think "FrozenSparseMerkleTree" -- you need to make sure nodes created between bottom layer and top layer don't go away while you read, by holding a strong ref to the bottom layer root.
areshand
approved these changes
Apr 4, 2024
zekun000
approved these changes
Apr 15, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
b941c9e
to
4a3f159
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A multi-versional mapping data structure much like the in memory sparse merkle tree but doesn't do the hashing on nodes.
This is useful for implementing the per-block speculative LRU cache / Active State coming up.
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
proptest
Key Areas to Review
Checklist