Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drive icon to reflect drive type #717

Open
dlech opened this issue Sep 23, 2016 · 7 comments
Open

Update drive icon to reflect drive type #717

dlech opened this issue Sep 23, 2016 · 7 comments

Comments

@dlech
Copy link
Contributor

dlech commented Sep 23, 2016

This idea follows on #716. The idea is for the drive icon and text to be updated when a drive is selected to keep the behavior patterns of the program the same for each step of the 3 steps shown.

Since the disk image icon and text can be updated when an image is selected, it follows that the disk drive icon and text should be updated in a similar manner. Here is an example...

etcher_009_mod

I don't know what kind of info is available from the OS about what type a drive is connected (e.g. USB/SD card/etc.) but it would be slick if the icon could be updated to show what type of drive was selected.

@alexandrosm
Copy link
Contributor

We really wanted to make the icon be updated on usb/sd drive, but it seems
there's no reliable way to tell, especially across platforms. it would even
be cool if we could do it in a subset of cases we could detect, but we've
found no way to get even partial information as of yet.

Alexandros Marinos

Founder & CEO, Resin.io

+1 206-637-5498

@alexandrosm

On Fri, Sep 23, 2016 at 10:57 AM, David Lechner notifications@github.com
wrote:

This idea follows on #716 #716.
The idea is for the drive icon and text to be updated when a drive is
selected to keep the behavior patterns of the program the same for each
step of the 3 steps shown.

Since the disk image icon and text can be updated when an image is
selected, it follows that the disk drive icon and text should be updated in
a similar manner. Here is an example...

[image: etcher_009_mod]
https://cloud.githubusercontent.com/assets/963645/18796042/145ee114-818d-11e6-9de4-f69b03d902ad.png

I don't know what kind of info is available from the OS about what type a
drive is connected (e.g. USB/SD card/etc.) but it would be slick if the
icon could be updated to show what type of drive was selected.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#717, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABLUCNla3dASBrUgZ_C7frd9yDy4Y4gZks5qtBMjgaJpZM4KFPBF
.

@alexandrosm
Copy link
Contributor

otherwise, I do agree on both the suggestions and indeed we've discussed
similar changes in the past. This is a good nudge to revise that
conversation (pinging @taahirisaacs)

Alexandros Marinos

Founder & CEO, Resin.io

+1 206-637-5498

@alexandrosm

On Fri, Sep 23, 2016 at 12:26 PM, Alexandros Marinos alexandros@resin.io
wrote:

We really wanted to make the icon be updated on usb/sd drive, but it seems
there's no reliable way to tell, especially across platforms. it would even
be cool if we could do it in a subset of cases we could detect, but we've
found no way to get even partial information as of yet.

Alexandros Marinos

Founder & CEO, Resin.io

+1 206-637-5498

@alexandrosm

On Fri, Sep 23, 2016 at 10:57 AM, David Lechner notifications@github.com
wrote:

This idea follows on #716 #716.
The idea is for the drive icon and text to be updated when a drive is
selected to keep the behavior patterns of the program the same for each
step of the 3 steps shown.

Since the disk image icon and text can be updated when an image is
selected, it follows that the disk drive icon and text should be updated in
a similar manner. Here is an example...

[image: etcher_009_mod]
https://cloud.githubusercontent.com/assets/963645/18796042/145ee114-818d-11e6-9de4-f69b03d902ad.png

I don't know what kind of info is available from the OS about what type a
drive is connected (e.g. USB/SD card/etc.) but it would be slick if the
icon could be updated to show what type of drive was selected.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#717, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABLUCNla3dASBrUgZ_C7frd9yDy4Y4gZks5qtBMjgaJpZM4KFPBF
.

@dlech
Copy link
Contributor Author

dlech commented Sep 23, 2016

Yes, detecting this would be very platform-specific. It looks like you are already getting this info for Linux but just not saving it.

@dlech
Copy link
Contributor Author

dlech commented Sep 23, 2016

So, essentially, this issue is blocked by balena-io-modules/drivelist#64

@alexandrosm
Copy link
Contributor

nice! I'd be up for doing it in platforms that support it.

Alexandros Marinos

Founder & CEO, Resin.io

+1 206-637-5498

@alexandrosm

On Fri, Sep 23, 2016 at 1:38 PM, David Lechner notifications@github.com
wrote:

So, essentially, this issue is blocked by balena-io-modules/drivelist#64
balena-io-modules/drivelist#64


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#717 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABLUCChSYelxYu4gSRso6G1OA7z6I9dIks5qtDipgaJpZM4KFPBF
.

@jviotti jviotti changed the title Update drive icon/text similar to the way image icon/text are update when metadata is present Update drive icon to reflect drive type Sep 26, 2016
@jviotti
Copy link
Contributor

jviotti commented Sep 26, 2016

I definitely agree with this change. Maybe we can get the ball rolling for just Linux for now (seems to be the lowest hanging fruit)?

@jviotti jviotti modified the milestone: Backlog Nov 28, 2016
@jviotti jviotti modified the milestones: Backlog, Experience Dec 7, 2016
@lurch
Copy link
Contributor

lurch commented Feb 23, 2018

As Alex said earlier, this info seems to be very unreliable; even on desktop Ubuntu 16.04 my SD card-reader gets shown with a CompactFlash icon 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants