Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and package ARM releases #3896

Closed
wants to merge 2 commits into from
Closed

Build and package ARM releases #3896

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81355b6
Build and package ARM releases
ab77 Nov 9, 2022
19df114
remove win-arm64 experiments
ab77 Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
remove win-arm64 experiments
  • Loading branch information
@ab77
ab77 committed Jan 5, 2023
commit 19df114a099cefa1595db7c7531967c5006ce438
25 changes: 6 additions & 19 deletions .github/actions/publish/action.yml
View file
Open in desktop
Expand Up @@ -15,10 +15,10 @@ inputs:
default: "accounts+apple@balena.io"
NODE_VERSION:
type: string
default: "16.19.0"
default: "16.x"
VERBOSE:
type: string
default: "true"
default: "false"

runs:
# https://docs.github.com/en/actions/creating-actions/creating-a-composite-action
Expand Down Expand Up @@ -91,8 +91,6 @@ runs:
run: |
set -ea

[[ '${{ inputs.VERBOSE }}' =~ on|On|Yes|yes|true|True ]] && set -x

branch="$(echo '${{ github.event.pull_request.head.ref }}' | sed 's/[^[:alnum:]]/-/g')"

stdout="$(resinci-deploy store sentry \
Expand All @@ -102,6 +100,7 @@ runs:
--org="$(yq e '.sentry.org' repo.yml)" \
--type="$(yq e '.sentry.type' repo.yml)")"

echo "::add-mask::${stdout}"
echo "dsn=$(echo "${stdout}" | tail -n 1)" >> $GITHUB_OUTPUT

env:
Expand Down Expand Up @@ -180,22 +179,13 @@ runs:
for arch in ${archs[*]}; do
# (re)build|pack for all non-x64 architectures
if ! [[ "$arch" =~ x64 ]]; then
# FIXME: remove when Node.js win-arm64 support ships
# https://github.com/nodejs/build/issues/2450#issuecomment-1367786829
if [[ "$runner_os" =~ win ]] && [[ "$arch" =~ arm64 ]]; then
find "$(dirname $(which node))/.." -type f -name node-gyp.js \
| xargs -I{} node {} install \
--dist-url=https://unofficial-builds.nodejs.org/download/release
fi

npm ci

find node_modules -type d \( -name 'prebuilds' -o -name 'deps' \) \
| xargs -L1 -I{} find {} -type f

npm run build
fi

find node_modules -type d \( -name 'prebuilds' -o -name 'deps' \) \
| xargs -L1 -I{} find {} -type f

electron-builder "--${ELECTRON_BUILDER_OS}" "${target}" "--${arch}" \
--c.extraMetadata.analytics.sentry.token='${{ steps.sentry.outputs.dsn }}' \
--c.extraMetadata.analytics.mixpanel.token='balena-etcher' \
Expand All @@ -214,9 +204,6 @@ runs:
# https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks
# https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks#about-workflow-runs-from-public-forks
CSC_FOR_PULL_REQUEST: true
# https://www.electron.build/#debug
DEBUG: electron-builder
NPM_CONFIG_loglevel: verbose

# https://www.electron.build/auto-update.html#staged-rollouts
- name: Configure staged rollout(s)
Expand Down
5 changes: 2 additions & 3 deletions .github/actions/test/action.yml
View file
Open in desktop
Expand Up @@ -12,10 +12,10 @@ inputs:
# --- custom environment
NODE_VERSION:
type: string
default: "16.19.0"
default: "16.x"
VERBOSE:
type: string
default: "true"
default: "false"

runs:
# https://docs.github.com/en/actions/creating-actions/creating-a-composite-action
Expand Down Expand Up @@ -54,7 +54,6 @@ runs:
env:
# https://www.electronjs.org/docs/latest/api/environment-variables
ELECTRON_NO_ATTACH_CONSOLE: true
NPM_CONFIG_loglevel: verbose

- name: Compress custom source
shell: pwsh
Expand Down